Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.2.2 not support SSR #1487

Closed
ycjcl868 opened this issue Sep 18, 2019 · 4 comments
Closed

v3.2.2 not support SSR #1487

ycjcl868 opened this issue Sep 18, 2019 · 4 comments

Comments

@ycjcl868
Copy link

ycjcl868 commented Sep 18, 2019

relate commit ace1a9d.

image

In node env, there's no Intl.RelativeTimeFormat, so it will throw Error.

In my opinion, it's a breaking change, it shouldn't block the main process in Server-Side render

image

@longlho
Copy link
Member

longlho commented Sep 18, 2019 via email

@zombieJ
Copy link

zombieJ commented Sep 18, 2019

@longlho,
Do not bring breaking change in patch version. This should move to minor version or use console warning in patch version instead.

@longlho
Copy link
Member

longlho commented Sep 18, 2019

Actually that was a mistake on our part. It has always required Intl.RelativeTimeFormat, just lazily. Publishing a fix now.

@longlho
Copy link
Member

longlho commented Sep 18, 2019

fixed in 3.2.3. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants