Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify connectors #102

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Unify connectors #102

merged 3 commits into from
Jul 20, 2020

Conversation

formatc1702
Copy link
Collaborator

@formatc1702 formatc1702 commented Jul 19, 2020

Closes #78.

  • Code has been adapted, all references to "ferrules" as separate connector type have been eliminated.
  • The simplified look of a ferrule can be achieved by adding a style: simple attribute to a connector.
    • This simply eliminates the list of pins inside the node, and causes connected wires to attach to the node itself, rather than a subport
    • The simple style is only allowed for connectors with one [electrical] port:
  • The auto-generation of simple connectors is achieved by the autogenerate: true attribute
  • Autogenerated connectors hide their (also autogenerated) name by default, and their designators are not listed in the respective BOM column
  • Some examples have been updated/simplified to work with these changes

@formatc1702 formatc1702 added this to the v0.2 milestone Jul 19, 2020
Copy link
Collaborator

@kvid kvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the more compact code versions are not less readable.

src/wireviz/DataClasses.py Outdated Show resolved Hide resolved
src/wireviz/DataClasses.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kvid kvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the more compact way to specify connections in the YAML file.

@formatc1702 formatc1702 force-pushed the feature/unify-connectors branch from a92ca58 to 8f833d9 Compare July 20, 2020 06:22
@formatc1702 formatc1702 merged commit 8f833d9 into dev Jul 20, 2020
@formatc1702 formatc1702 deleted the feature/unify-connectors branch July 20, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants