-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using multiple color for wire makes ugly output #131
Comments
Currently, rendered wire thickness it is decided per cable/bundle: if any of the wires of a cable/bundle is multicolored, all the single-colored ones in that group are rendered in the same thickness. This change was introduced in 8cba793. I agree that the output above does not look like a user would probably expect, so the check would have to happen on a harness level (is any wire in the entire harness multicolored?). I welcome a quick fix for this, but I will emphasize that wires should still be rendered in the thin style if no multicolored wires appear in the harness, so as not to make them unnecessarily thick. In the future (see #120) this whole issue should disappear anyway, unless a user specifically needs lengthwise striped wires as opposed to rings. |
I've made an adjustment in #132 that addresses the issue. I'm not sure it looks better than the picture posted above. Please keep in mind that currently, WireViz has little control over how the wires are actually routed in the graphical output; the sometimes wonky bends are purely a GraphViz-related effect. |
Yes I know, I've tried to play with it and got very frustrated too by this wavy rendering of graphviz. I prefer the version below than the one above. |
I'm using the dev branch as of today (last commit: b9a4783 )
I'm using the example code as given in my comment in PR #120
I'm getting this output:
I'd have expected that wires all have the same thickness, but they don't.
The text was updated successfully, but these errors were encountered: