Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer instanceUrl for loginUrl on user:create #518

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

mshanemc
Copy link
Contributor

improve post-user creation auth by using instanceUrl over loginUrl (see gh issue for testing repro).

has been confirmed by customer that the fix works (see gh issue)

note about the note on the issue:
I did try deleting the org using plugin-org linked to this version of core, with no issues.

Testing notes--this only causes problem for community user create with jwt and on Summer22 orgs

@W-10494033@
forcedotcom/cli#1365

@cristiand391
Copy link
Member

QA notes:

Repro using na40:

badUser

✅ plugin-user can create new user when using jwt

badUser1

authList

@cristiand391 cristiand391 merged commit c070a87 into main Feb 10, 2022
@cristiand391 cristiand391 deleted the sm/community-user-create-auth branch February 10, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants