feat: adds seedMetadata for package version creation command #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshnt
approved these changes
Jan 24, 2023
| "packageDirectory.seedMetadata": { | ||
| "type": "object", | ||
| "title": "Seed Metadata", | ||
| "description": "Metadata not meant to be packaged, but deployed before deploying packaged metadata", |
There was a problem hiding this comment.
does this text appear on CLI help? if yes, then it must be reviewed with Doc writers
There was a problem hiding this comment.
No, the schema isn't used when displaying CLI help text. That would come from (in this case) plugin-packaging.
shetzel
approved these changes
Jan 25, 2023
gbockus-sf
approved these changes
Jan 25, 2023
tshopshireSalesforce
force-pushed
the
main
branch
from
bd10414 to
e60068e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds optional seedMetadata to the schema so unpackageable metadata can be pushed to the build org that the packaged metadata depends on, such as StandardValueSets. This is used for the package version create command.
What issues does this PR fix or reference?
@W-12204966@
Functionality Before
SeedMetadata could not be provided in the sfdx-project.json
Functionality After
SeedMetadata can be provided in the sfdx-project.json