Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo structure and fix circleci publish job #28

Merged
merged 10 commits into from
Oct 9, 2020

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Oct 9, 2020

What does this PR do?

This PR restructures the repository in order to fix publishing problems found when running in CircleCI.

  • Delete schema folder and its contents
  • Move the contents of schema folder to the top level
  • Delete prepare and postinstall script which used to move the above mentioned files
  • Update test references
  • Add a CircleCI job to store the generated tarball

What issues does this PR fix or reference?

@W-8148467@

@lcampos lcampos requested a review from a team as a code owner October 9, 2020 00:38
@lcampos lcampos requested review from amphro and ntotten October 9, 2020 00:39
@@ -1,807 +0,0 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntotten @amphro it's ok to move these files to the top level since those who reference them using the direct link to the repo are using the master branch. We've now replaced the master branch with main.

package.json Outdated
@@ -31,7 +29,7 @@
"commitizen": "^3.0.5",
"cz-conventional-changelog": "^2.1.0",
"ajv": "^6.10.2",
"husky": "^3.0.2",
"husky": "1.3.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfsholden I had to downgrade this to an older version because newer versions of husky fail to install when CircleCI install git version 2.11.0. I tried installing a newer version of git while building but that didn't work either. Do you have any suggestions on other things we could try ?

@lcampos lcampos merged commit b3469fc into main Oct 9, 2020
@lcampos lcampos deleted the lcampos/circleci-publish-fix branch October 9, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants