Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml files have useful links to other xml files #827

Closed
mshanemc opened this issue Dec 17, 2018 · 2 comments
Closed

xml files have useful links to other xml files #827

mshanemc opened this issue Dec 17, 2018 · 2 comments

Comments

@mshanemc
Copy link
Contributor

Is your feature request related to a problem? Please describe.
when working with .xml files, there are often links (to profiles, fields, objects, flexipages, etc)

Describe the solution you'd like
When looking in .xml files, if we know from the mdapi schema that something is a link, and can be resolved locally, we link it in vscode.

In the picture below, Entry_Record_Page is a file in the flexipage folder. It'd be nice to be able to follow that link.
screen shot 2018-12-17 at 1 44 50 pm

Each of these items on CompactLayout is a field
screen shot 2018-12-17 at 1 48 32 pm

This should link to a quickAction
screen shot 2018-12-17 at 1 50 49 pm

Describe alternatives you've considered
cmd-p searching the files by name and scrolling down the correct one and opening it

@vazexqi
Copy link
Contributor

vazexqi commented Dec 17, 2018

@lcampos This requires a language server for these files. The downside is that each one is a separate file with a different schema – it's an unfortunate consequence of us not settling on a canonical naming/symbol scheme for our metadata files.

We probably should prioritize and see which files are used the most and write language servers for them.

Since these files are just XML (no need for Java unlike Apex), we might be able to write these servers in TypeScript and take advantage of https://github.com/Microsoft/lsif-typescript This could be a way to combine all of them together.

This is not a small project. If we prioritize this we can come up with a scheme to address this piecewise though and provide value with each monthly release.

@ntotten ntotten added the feature label Jan 9, 2019
@ntotten
Copy link
Contributor

ntotten commented Jan 10, 2019

I am going to close this. It is a good idea, but since it is implemented in the XML language service this would be a major undertaking that we are unlikely to get to in any reasonable time period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants