Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give user feedback that the SFDX: Set a Default Org command is running when the default org button is clicked #1007

Closed
allileong opened this issue Feb 1, 2019 · 3 comments

Comments

@allileong
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There is a noticeable lag between the time when the default org button is clicked, and the quick-pick dropdown appears with the list of available orgs. In the time that it takes for the dropdown to appear, the user might be confused as to why clicking on the button had no visible effect and she may click on the org button a few more times. When the dropdown finally appears, in the case where she decides to select SFDX: Authorize an Org from the dropdown, she will have to go through a few more dropdown menus to set values such as the sfdcLoginUrl, org alias, etc. However, because the multiple clicks on the org button have queued up multiple invocations of the SFDX: Set a Default Org command, she is interrupted in her authorization flow by the re-appearance of the org list dropdown.

Describe the solution you'd like

  1. Block further invocations of SFDX: Set a Default Org when the command is already in progress.
  2. Change the icon of the default org button from the plug icon to a spinner icon when the command is in progress so that the user knows that the button press was heard and work is being done in the background. Otherwise, it is easy to mistakenly believe that the button is broken and nothing is happening.

Describe alternatives you've considered
Alternatively, we could have another progress notification appear in the status bar at the bottom of the vscode window when the SFDX: Set a Default Org command is in progress similar to the progress notification that appears when an SObject refresh is in progress.

@praksb
Copy link
Contributor

praksb commented Feb 1, 2019

@allileong I see the lag that you mentioned. Any idea what is causing the lag? Is it just all due to VS Code or are we doing some work before showing the UI that is causing the lag?

@lcampos
Copy link
Contributor

lcampos commented Feb 2, 2019

@allileong @praksb based on what I've seen, the lag is caused by us running sfdx force:config:setto get some of the info needed to populate the quick-pick dropdown. On top of preventing multiple executions of that command, we should also look at using the @salesforce/core module to get the info we need for these feature.

@lcampos
Copy link
Contributor

lcampos commented Apr 5, 2019

Closing this since it was addressed in release 45.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants