fix: update metadata mapping to handle no getter #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbockus-sf
commented
Oct 30, 2023
| loc = propertyObj.getter.location | ||
| } else if (propertyObj.setter) { | ||
| loc = propertyObj.setter.location | ||
| } |
There was a problem hiding this comment.
From local testing it appears there will be no property object without either a getter, setter, both, or a dataProperty. TheexternalToInternalLoc method handle the case where this value is empty.
gbockus-sf
commented
Oct 30, 2023
| ? propertyObj.getter.location | ||
| : propertyObj.dataProperty.location | ||
| ), | ||
| loc: externalToInternalLoc(loc), |
There was a problem hiding this comment.
Locally this project fails to compile for me. Not sure what's up with that.
CristiCanizales
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the javascript type mapping to handle the case where a class has a property with only a setter.
What issues does this PR fix or reference?
@W-14391061@
forcedotcom/salesforcedx-vscode#5069