Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add --forbid-only to husky hook, fix nyc file #47

Merged
merged 7 commits into from
Dec 17, 2021
Merged

Conversation

WillieRuemmele
Copy link
Member

@W-10290171@

will fix future projects when running yarn sf-install

.nycrc Outdated
"extends": "@salesforce/dev-config/nyc",
"check-coverage": true,
"lines": 90,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this fix mean it starts applying the 90 now? how does this interact with https://github.com/forcedotcom/dev-config/pull/3/files ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this repo had a custom nyc file - it wasn't in the correct format though. I'm sure we can have it use the default from dev-config. It doesn't have any tests anyways 🤷‍♂️

@cristiand391
Copy link
Member

QA notes

pre-push: yarn build && yarn test --forbid-only hook generated if no hook exist
✅ Added .only to a test, was able to commit but failed to push:

Error: `.only` forbidden by --forbid-only
...
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
husky - pre-push hook exited with code 1 (error)
error: failed to push some refs to 'github.com:salesforcecli/plugin-source.git'

@cristiand391 cristiand391 merged commit d3826e9 into main Dec 17, 2021
@cristiand391 cristiand391 deleted the wr/noOnly branch December 17, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants