-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add --forbid-only to husky hook, fix nyc file #47
Conversation
.nycrc
Outdated
"extends": "@salesforce/dev-config/nyc", | ||
"check-coverage": true, | ||
"lines": 90, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this fix mean it starts applying the 90 now? how does this interact with https://github.com/forcedotcom/dev-config/pull/3/files ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this repo had a custom nyc
file - it wasn't in the correct format though. I'm sure we can have it use the default from dev-config
. It doesn't have any tests anyways 🤷♂️
QA notes ✅
|
@W-10290171@
will fix future projects when running
yarn sf-install