-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: socket hang up don't return 1 #340
Comments
@alanjaouen we are taking a look, thank you for reporting |
Got the same Error since some Days ago.... It should be the latest Version of sfdx, because it is part of our CI that the latest Version of sfdx will be downloaded for the Deployment... [...] Because it is unhandled, the CI Process tries to deploy further and further.... Then later at some Point the Timeout stops the Process. |
got the same error today ERROR: Error: socket hang up |
Nobody assigned to this issue? @clairebianchi as you wrote last year, that somebody will take a look at this issue... Are there any News for this? Please don't get me wrong, but "sfdx" is quite essential for Salesforce Deployments.... Just wondering |
I've had similar errors twice today, and as others have reported, the job doesn't just not exit with failure, but looks like it hangs until some other timeout is hit. Once with a force:source:push, which failed, but then just sat there until the 10m no output timeout on my circleCI job expired
And once with an
Version:
|
Getting the same error on
As with others, this is crippling our Salesforce release pipeline. Whilst this had been happening occasionally in the past, since Spring '21 this has become an hourly occurrence. |
Encountered the socket hang up errors yesterday after installing the latest SFDX cli package. This is the error encounter for
This is my current SFDX CLI version.
|
reported similar issue here #529 (comment) |
We hit the same issue with To be clear: The bug here is that sfdx returns a successful status code. Salesforce regularly has production DNS issues, it's an unstable system, so it's not the fault of sfdx if Salesforce misconfigures their DNS records. It is a problem, however, that sfdx things a network error is a successful deploy. |
Any update on this issue? We are running force:source:deploy and issue is happening more frequently. CLI Version: sfdx-cli/7.93.1-762bca056d linux-x64 node-v14.15.4 ERROR: Error: socket hang up |
Wow this really hit home, given Salesforce took down their DNS globally for hours yesterday! |
W-6835454 for internal tracking. |
Hmm, I now propose this issue be closed. I don't think most people replying to this issue understand that this isn't an sfdx issue. Instead I propose two new tickets:
|
oh, network problems happens, but this is definitely sfdx issue with handling this situation. 'Unhandled rejection" - this shouldn't happen. This should be handled properly by sfdx. And of course the return code should indicate error (i.e. non zero)
|
This issue has been linked to a new work item: W-9299373 |
Using the old version of the I also tested with a very low command wait time (1 minute) and the command exited with a timeout error and an exit code of 1. |
Please reopen this ticket. We're getting this repeatedly. sfdx is notoriously poor at reporting status codes, I suggest an audit of all exits of sfdx. This is from
great, tests pass! sfdx is a dangerous tool, the output can't be trusted |
Summary
When running a
force:source:deploy
in a CI context, some error can occuredERROR: Error: socket hang up Unhandled rejection Error: socket hang up at createHangUpError (_http_client.js:323:15) at TLSSocket.socketOnEnd (_http_client.js:426:23) at TLSSocket.emit (events.js:194:15) at endReadableNT (_stream_readable.js:1125:12) at process._tickCallback (internal/process/next_tick.js:63:19)
Expected result
Return 1 so we can handle it's an error
Actual result
Return 0
Additional information
SFDX CLI Version(to find the version of the CLI engine run sfdx --version):
sfdx-cli/7.49.1-2b6ba86a25 linux-x64 node-v10.15.3
OS and version:
linux-x64
The text was updated successfully, but these errors were encountered: