`sfdx force:org:create` fails on converting circular structure to JSON #1928

pawel-id · 2023-02-11T12:07:09Z

Summary

sfdx force:org:create fails on converting circular structure to JSON. This fails when default Devhub username is set and SFDX_LOG_LEVEL variable is provided. It crashes even without any parameters to sfdx force:org:create.

Steps To Reproduce:

setup default Devhub username with any command e.g.: sfdx auth sfdxurl store -f auth.txt -a prod -d (note option -d)
issue the command SFDX_LOG_LEVEL=debug sfdx force:org:create

Expected result

Regular message about lacking params of force:org:create command.

Actual result

an error:

TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Timeout'
    |     property '_idlePrev' -> object with constructor 'TimersList'
    --- property '_idleNext' closes the circle
    at JSON.stringify (<anonymous>)
    at /Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:702:31
    at Array.map (<anonymous>)
    at filterSecrets (/Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:691:41)
    at /Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:142:37
    at /Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:617:61
    at Array.forEach (<anonymous>)
    at Logger.applyFilters (/Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:617:33)
    at Logger.debug (/Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/core/lib/logger.js:514:32)
    at Create.run (/Users/pawel/.nvm/versions/node/v18.14.0/lib/node_modules/sfdx-cli/node_modules/@salesforce/plugin-org/lib/commands/force/org/create.js:26:21)

System Information

{
  "cliVersion": "sfdx-cli/7.187.1",
  "architecture": "linux-arm64",
  "nodeVersion": "node-v18.14.0",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 1.4.4 (core)",
    "@oclif/plugin-commands 2.2.5 (core)",
    "@oclif/plugin-help 5.2.2 (core)",
    "@oclif/plugin-not-found 2.3.17 (core)",
    "@oclif/plugin-plugins 2.3.0 (core)",
    "@oclif/plugin-search 0.0.11 (core)",
    "@oclif/plugin-update 3.1.1 (core)",
    "@oclif/plugin-version 1.2.1 (core)",
    "@oclif/plugin-warn-if-update-available 2.0.24 (core)",
    "@oclif/plugin-which 2.2.12 (core)",
    "alias 2.2.0 (core)",
    "apex 1.5.0 (core)",
    "auth 2.4.0 (core)",
    "community 2.2.0 (core)",
    "config 1.5.0 (core)",
    "custom-metadata 2.1.0 (core)",
    "data 2.2.0 (core)",
    "generator 2.0.17 (core)",
    "info 2.4.0 (core)",
    "limits 2.3.0 (core)",
    "org 2.3.0 (core)",
    "packaging 1.14.1 (core)",
    "schema 2.3.0 (core)",
    "signups 1.4.0 (core)",
    "source 2.4.1 (core)",
    "telemetry 2.1.0 (core)",
    "templates 55.3.0 (core)",
    "trust 2.4.0 (core)",
    "user 2.3.0 (core)",
    "@salesforce/sfdx-plugin-lwc-test 1.0.1 (core)",
    "salesforce-alm 54.8.5 (core)"
  ],
  "osVersion": "Linux 5.15.49-linuxkit",
  "shell": "unknown",
  "rootPath": "/usr/local/lib/node_modules/sfdx-cli"
}

Additional information

it fails same way on latest-rc 7.188.1

might be related to:

The text was updated successfully, but these errors were encountered:

github-actions · 2023-02-11T12:07:26Z

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

jeromegv · 2023-02-11T14:57:12Z

Confirming I have the same issue on a Bitbucket pipeline

MathieuCaveSF · 2023-02-11T15:44:22Z

Me too on bitbucket pipeline

Amoliere · 2023-02-13T10:32:20Z

Same issue on my Side on Bitbucet also, I changed the image from my pipeline
"image: salesforce/salesforcedx:7.186.0-slim"
instead of
"image: salesforce/salesforcedx:latest-slim"
and it worked again for me.

But it's not an explanation on the root cause we faced at the beginning.

git2gus · 2023-02-13T14:37:03Z

This issue has been linked to a new work item: W-12535806

mshanemc · 2023-02-13T14:37:47Z

I can reproduce this locally, no CI involved. I see the bug happen down in the logging framework, trying to figure out why and how to prevent it.

dalden1981 · 2023-02-13T17:34:42Z

~~Same error on sfdx force:package:version:create~~
Fixed by reading #1907

tehnrd · 2023-02-14T16:31:37Z

Confirming this is occurring in Github Actions as well, but glad @mshanemc was able to reproduce locally.

~~A bit of a blocking issue, so hopefully, this gets a priority fix.~~

Rolling back to 7.186.2 fixed it for me. I've started to call out a specific version in my CI/CD scripts for stability.

npm install [email protected] --global

mshanemc · 2023-02-14T19:08:18Z

best workaround so far: SFDX_LOG_LEVEL=info instead of debug.

another: SF_DISABLE_LOG_FILE=true to ensure you log nothing.

jdatskuid · 2023-03-31T20:09:04Z

Just to confirm that I am also seeing this error in our CI builds:

sfdx-cli/7.194.1 linux-x64 node-v18.13.0
Successfully authorized ******** with org ID 00D40000000Mw0SEAS
jwt grant succeeded to hub org

> create-scratch-org
> sfdx force:org:create -v HubOrg -s -f config/project-scratch-def.json -a ciorg -d 1 --wait 60

Error (1): Converting circular structure to JSON
    --> starting at object with constructor 'Timeout'
    |     property '_idlePrev' -> object with constructor 'TimersList'
    --- property '_idleNext' closes the circle

When I set SFDX_LOG_LEVEL=info (as in SFDX_LOG_LEVEL=info sfdx force:org:create ...) the deployment succeeds.

Kevmo92 · 2023-04-03T14:22:52Z

best workaround so far: SFDX_LOG_LEVEL=info instead of debug.

Why is debug is the default?

cristiand391 · 2023-04-03T15:00:13Z

@Kevmo92 there's no default log level, this only happens if you set SFDX_LOG_LEVEL=debug

Kevmo92 · 2023-04-04T14:53:05Z

@cristiand391 Why isn't there a default log level set 🤔

Kevmo92 · 2023-04-05T13:45:47Z

@mshanemc Instead of consumers implementing a workaround would it make more sense for a default log level to be set in the cli that's attempting to log?

mshanemc · 2023-04-05T14:04:40Z

@Kevmo92 do you get the error without setting SFDX_LOG_LEVEL ?

jdatskuid · 2023-04-05T15:11:10Z

For our CI builds, we want as much info as reasonable in the logs so that, when a build breaks, it's easier to diagnose the issue. We set a global ENV SFDX_LOG_LEVEL DEBUG for all of our sfdx commands right in the Dockerfile, but I am now overriding that with SFDX_LOG_LEVEL=info for the buggy commands (sfdx org:create:scratch).

It's unfortunate as I would prefer to have that extra level of log information (I assume that's what "debug" is for... debugging), but stepping down to info allowed our CI environment to finish a build without errors.

jdatskuid · 2023-04-05T15:14:29Z

@cristiand391 @Kevmo92 According to Salesforce CLI Configuration and Tips / Log Messages and Log Levels:

The default level of log messages is warn.

cristiand391 · 2023-04-05T16:29:35Z

@jdatskuid I think that was being set here:
https://github.com/salesforcecli/command/blob/main/src/sfdxFlags.ts#L528

So, commands supporting--log-level would have log level set to warn even if they didn't specify --loglevel warn when running a command because the flag had a default value.

That code was deprecated and removed for almost all commands now, and using that flag just prints a msg showing how to set the log level using the env var:
https://github.com/salesforcecli/sf-plugins-core/blob/de7f99d9c53410cfe6a514a00e45202aafcd35a0/src/compatibility.ts#L37-L49

I'll double-check with my team, otherwise we'll update the docs.

cristiand391 · 2023-04-05T18:07:48Z

@jdatskuid A teammate mentioned the default log level set is still set to warn in the logger class:
https://github.com/forcedotcom/sfdx-core/blob/main/src/logger.ts#L208

While it's not exactly set as a global in sfdx like with the --loglevel flag, the default still applies unless a plugin/lib sets a different level.

To sum up:

default log level warn is set in the logger utility used by plugins/libraries.
--loglevel is deprecated and no longer sets log level, you should always set it via the SFDX_LOG_LEVEL env var.

Kevmo92 · 2023-05-01T14:29:39Z

@Kevmo92 do you get the error without setting SFDX_LOG_LEVEL ?

yes

Kevmo92 · 2023-05-01T14:37:16Z

Are there any plans to work on a fix that doesn't require an environment variable to be set? Could sfdx cli set the "necessary" env variable in the users session if it's not set? Or is the plan to just replace the logger system and let this issue linger in the meantime?

shetzel · 2023-05-01T16:07:40Z

@Kevmo92 - Yes there are plans to fix the log level bug. However, there are 2 workarounds to this issue:

unset SFDX_LOG_LEVEL
Use the newer command for creating orgs: org create scratch

cristiand391 · 2023-06-21T19:04:06Z

fixed here: salesforcecli/plugin-org#708

and already available on latest CLI.

pawel-id added the investigating We're actively investigating this issue label Feb 11, 2023

mshanemc added the bug Issue or pull request that identifies or fixes a bug label Feb 13, 2023

mshanemc added the logger-replacement label Apr 5, 2023

cristiand391 closed this as completed Jun 21, 2023

mshanemc mentioned this issue Jul 7, 2023

Sm/new logger forcedotcom/sfdx-core#876

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`sfdx force:org:create` fails on converting circular structure to JSON #1928

`sfdx force:org:create` fails on converting circular structure to JSON #1928

pawel-id commented Feb 11, 2023

github-actions bot commented Feb 11, 2023

jeromegv commented Feb 11, 2023

MathieuCaveSF commented Feb 11, 2023

Amoliere commented Feb 13, 2023

git2gus bot commented Feb 13, 2023

mshanemc commented Feb 13, 2023

dalden1981 commented Feb 13, 2023 •

edited

Loading

tehnrd commented Feb 14, 2023 •

edited

Loading

mshanemc commented Feb 14, 2023 •

edited

Loading

jdatskuid commented Mar 31, 2023

Kevmo92 commented Apr 3, 2023

cristiand391 commented Apr 3, 2023

Kevmo92 commented Apr 4, 2023

Kevmo92 commented Apr 5, 2023

mshanemc commented Apr 5, 2023

jdatskuid commented Apr 5, 2023

jdatskuid commented Apr 5, 2023

cristiand391 commented Apr 5, 2023

cristiand391 commented Apr 5, 2023

Kevmo92 commented May 1, 2023

Kevmo92 commented May 1, 2023

shetzel commented May 1, 2023

cristiand391 commented Jun 21, 2023

sfdx force:org:create fails on converting circular structure to JSON #1928

sfdx force:org:create fails on converting circular structure to JSON #1928

Comments

pawel-id commented Feb 11, 2023

Summary

Steps To Reproduce:

Expected result

Actual result

System Information

Additional information

github-actions bot commented Feb 11, 2023

jeromegv commented Feb 11, 2023

MathieuCaveSF commented Feb 11, 2023

Amoliere commented Feb 13, 2023

git2gus bot commented Feb 13, 2023

mshanemc commented Feb 13, 2023

dalden1981 commented Feb 13, 2023 • edited Loading

tehnrd commented Feb 14, 2023 • edited Loading

mshanemc commented Feb 14, 2023 • edited Loading

jdatskuid commented Mar 31, 2023

Kevmo92 commented Apr 3, 2023

cristiand391 commented Apr 3, 2023

Kevmo92 commented Apr 4, 2023

Kevmo92 commented Apr 5, 2023

mshanemc commented Apr 5, 2023

jdatskuid commented Apr 5, 2023

jdatskuid commented Apr 5, 2023

cristiand391 commented Apr 5, 2023

cristiand391 commented Apr 5, 2023

Kevmo92 commented May 1, 2023

Kevmo92 commented May 1, 2023

shetzel commented May 1, 2023

cristiand391 commented Jun 21, 2023

`sfdx force:org:create` fails on converting circular structure to JSON #1928

`sfdx force:org:create` fails on converting circular structure to JSON #1928

dalden1981 commented Feb 13, 2023 •

edited

Loading

tehnrd commented Feb 14, 2023 •

edited

Loading

mshanemc commented Feb 14, 2023 •

edited

Loading