Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further support for custom browser specification #1852

Closed
stohn777 opened this issue Dec 23, 2022 · 3 comments
Closed

Further support for custom browser specification #1852

stohn777 opened this issue Dec 23, 2022 · 3 comments
Labels
feature Issue or pull request for a new feature help wanted Help wanted to implement this issue

Comments

@stohn777
Copy link

Is your feature request related to a problem? Please describe.
No, and thank you for the -b flag on force:org:open that enables a more customizable experience with sfdx.

What are you trying to do
Having both Firefox and Firefox Developer installed, the new force:org:open -b flag for "firefox" opens the standard version, whereas for development work I prefer Firefox Developer.

Also I've seen comments asking about incognito or private browser instances.

Describe the solution you'd like
Explicitly supporting all permutations of browsers and options would quickly get out of hand. Therefore a more flexible solution is needed.

Enable the user to specify, perhaps in the config hierarchy, the browser program and options to be executed. In a Windows, private-window Firefox Developer situation, the config setting could be similar to "browser": "c:/Program Files/Firefox Developer Edition/firefox.exe -private-window". The syntax for supporting folders containing spaces is TBD. Perhaps the most canonical styles could be supported.

When an sfdx command offers the -b flag, provide a -B flag that takes the "path/program -flags" syntax. sfdx force:org:open -B "c:/Program Files/Firefox Developer Edition/firefox.exe -private-window". Again that path, file name, flags syntax is TBD.

The precedence would be:

  1. Command specified browser
  2. Config-sourced browser
  3. OS default browser

Describe alternatives you've considered
None. But I'm happy to evolve the feature with others.

Additional context
None.

@stohn777 stohn777 added the feature Issue or pull request for a new feature label Dec 23, 2022
@git2gus
Copy link

git2gus bot commented Dec 23, 2022

This issue has been linked to a new work item: W-12264011

@github-actions
Copy link

Thank you for filing this feature request. We appreciate your feedback and will review the feature at our next grooming or sprint planning session. We prioritize feature requests with more upvotes and comments.

@WillieRuemmele WillieRuemmele added the help wanted Help wanted to implement this issue label Jun 26, 2023
@WillieRuemmele
Copy link
Member

We use the open library to open the browser here

adding those flags would be pretty easy to pass to the library as arguments

@forcedotcom forcedotcom locked and limited conversation to collaborators Jun 26, 2023
@WillieRuemmele WillieRuemmele converted this issue into discussion #2262 Jun 26, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature Issue or pull request for a new feature help wanted Help wanted to implement this issue
Projects
None yet
Development

No branches or pull requests

2 participants