Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The use of use_frameworks! #252

Closed
mjmasn opened this issue Nov 8, 2021 · 5 comments
Closed

The use of use_frameworks! #252

mjmasn opened this issue Nov 8, 2021 · 5 comments

Comments

@mjmasn
Copy link
Contributor

mjmasn commented Nov 8, 2021

This might be more of a question for the https://github.com/forcedotcom/SalesforceMobileSDK-iOS project but posting here because it affects React Native in particular.

Is there a reason we need to use use_frameworks! in the Podfile / is there any way to avoid having to do this?

I think back in 8.3 we could modify an import or two and remove use_frameworks! with no ill effects. With 9.2 it just causes a long string of errors that I haven't been able to resolve.

With the way the React Native ecosystem is heading it seems to be frowned upon to use use_frameworks! and it's actually totally broken if trying to use Hermes or Flipper.

We're between a rock and a hard place at the moment because with the React Native 0.66 upgrade we also needed to upgrade React Native Reanimated to version 2, which uses turbomodules and therefore crashes if we try to use chrome debugger on Android. But we can't switch to Hermes which would allow direct debugging via Flipper because we can't enabled either Hermes or Flipper without getting build errors (cause by use_frameworks) on iOS.

Related reading:
facebook/react-native#32451
facebook/hermes#548
react-native-community/discussions-and-proposals#206
software-mansion/react-native-reanimated#1663 (comment)

@hugo-chq
Copy link

hugo-chq commented Nov 23, 2021

Also running into an issue trying to use Reanimated 2 (seemingly related to use_frameworks),
even now that Reanimated 2 doesn't rely on turbomodules, it unfortunately still can't be used as is

@hugo-chq
Copy link

hugo-chq commented Nov 24, 2021

Looks like the Reanimated issue might be resolvable with Reanimated 2 beta 3 2.2.4, and this change to from @mjmasn software-mansion/react-native-reanimated#2525 (comment)

where they mention AppDelegate.m/.h weren't updated with changes match the latest react-native default starter project,
https://react-native-community.github.io/upgrade-helper/?from=0.58.6&to=0.66.0

would it be possible to get those AppDelegate changes ( mostly related to RCTBridgeDelegate ) in this starter project, or are they potentially incompatible? thanks

@gkotula
Copy link

gkotula commented Aug 23, 2022

Hi everyone, is the use of use_frameworks! still causing issues, or is the latest version of Mobile SDK working when integrating Flipper or Hermes?

As far as the AppDelegate changes, we will take a look at it, thanks!

@wmathurin
Copy link
Contributor

In our upcoming version of Mobile SDK (10.2), we are no longer using use_frameworks in our template app pod files.
See forcedotcom/SalesforceMobileSDK-Templates#348

@mjmasn
Copy link
Contributor Author

mjmasn commented Oct 3, 2022

Fantastic, thanks for the update @wmathurin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants