rewrite test_get_recovery_data #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was pulling my hair out with some py3 compatability, so .. I ended up basically rewriting it. Basically a big refactor, still compatible with py2.
tedder
added a commit
to tedder/OctoPrint
that referenced
this pull request
Sep 2, 2018
Some prepwork for py3. Tossing these together: - assertItemsEqual doesn't do what it says on the box. It only said "hey, these lists have the same number of items". Not content or anything. Changing that to SetEqual, which is much closer to what is wanted- ensuring that lists have the same content without caring about their order. - use assertRaises instead of try/catch - update some mocks, especially mock_open. - include the refactored test_get_recovery_data sent to the maintenance branch in OctoPrint#2806.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
py3 compatability: I was pulling my hair out with some py3 compatability, so .. I ended up basically rewriting this test. Basically a big refactor, still compatible with py2.
How was it tested? How can it be tested by the reviewer?
with
noseAny background context you want to provide?
What are the relevant tickets if any?
Screenshots (if appropriate)
Further notes