Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estimatedPrintTime is in seconds, not minutes #2697

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

eyal0
Copy link
Contributor

@eyal0 eyal0 commented Jun 24, 2018

The documentation says that the estimated print time should be given in minute. But in practice, when I give it in minutes, the GUI shows an error factor of 60. By supplying it in seconds, the correct value is shown.

So it should probably actually be "in seconds"

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch, or maintenance if it's
    a bug fix for an issue present in the current stable version (no PRs
    against master or anything else please)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance or devel please),
    e.g. dev/my_new_feature or fix/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated with
    lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

The comment about estimatedPrintTime was wrong, it says minutes but it should be seconds

How was it tested? How can it be tested by the reviewer?

I uploaded a file using a slicer that reports estimatedPrintTime and I observed the the GUI displays seconds, not minutes.

Any background context you want to provide?

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

The documentation says that the estimated print time should be given in minute.  But in practice, when I give it in minutes, the GUI shows an error factor of 60.  By supplying it in seconds, the correct value is shown.

So it should probably actually be "in seconds"
@foosel foosel changed the base branch from devel to maintenance June 25, 2018 09:07
@foosel foosel merged commit 08c384a into OctoPrint:maintenance Jun 25, 2018
@foosel foosel added this to the 1.3.10 milestone Oct 31, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants