estimatedPrintTime is in seconds, not minutes #2697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation says that the estimated print time should be given in minute. But in practice, when I give it in minutes, the GUI shows an error factor of 60. By supplying it in seconds, the correct value is shown.
So it should probably actually be "in seconds"
to a large audience (ideally all users of OctoPrint)
made sure your changes don't interfere with current development by
talking it through with the maintainers, e.g. through a
Brainstorming ticket
a bug fix for an issue present in the current stable version (no PRs
against master or anything else please)
(no PRs from your version of master, maintenance or devel please),
e.g. dev/my_new_feature or fix/my_bugfix
no dead code, ideally only one commit - rebase and squash your PR
if necessary!
.less source files, not the .css files (those are generated with
lessc)
have added unit tests
nothing broke
What does this PR do and why is it necessary?
The comment about estimatedPrintTime was wrong, it says minutes but it should be seconds
How was it tested? How can it be tested by the reviewer?
I uploaded a file using a slicer that reports estimatedPrintTime and I observed the the GUI displays seconds, not minutes.
Any background context you want to provide?
What are the relevant tickets if any?
Screenshots (if appropriate)
Further notes