Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.3.10] SVG Favicon doesn't show in Firefox #2879

Closed
foosel opened this issue Nov 8, 2018 · 4 comments
Closed

[1.3.10] SVG Favicon doesn't show in Firefox #2879

foosel opened this issue Nov 8, 2018 · 4 comments
Assignees
@foosel
Labels
bug Issue describes a bug done Done but not yet released
Milestone
1.3.10

Comments

@foosel
Copy link
Member

foosel commented Nov 8, 2018 •
edited
Loading

Problem

Firefox doesn't show the new SVG Favicon:

image

According to this comment and this link this seems to be due to the used mime type. Doesn't seem to be the mime type, that's already set to image/svg+xml.
@foosel foosel added the bug Issue describes a bug label Nov 8, 2018
@foosel foosel added this to the 1.3.10 milestone Nov 8, 2018
@foosel foosel self-assigned this Nov 8, 2018
@foosel foosel mentioned this issue Nov 8, 2018
Closed
@foosel
Copy link
Member Author

foosel commented Nov 8, 2018

Correct mime type is already set, favicon still doesn't show up. Investigating...

foosel added a commit that referenced this issue Nov 8, 2018
@foosel
Give the favicon mask SVG width and height attrs
1ec61a9 
Otherwise it won't render correctly in Firefox due to drawImage silently
failing, see also https://bugzilla.mozilla.org/show_bug.cgi?id=700533

Closes #2879
@foosel foosel added the done Done but not yet released label Nov 8, 2018
@foosel
Copy link
Member Author

foosel commented Nov 8, 2018

Fixed by the above commit. The issue was actually that drawing a SVG to a canvas used internally fails silently in Firefox if the SVG doesn't have width and height attributes. Simply adding those solved the issue immediately.

Pushed and ready for 1.3.10rc2

@ThaliaFP
Copy link

ThaliaFP commented Nov 9, 2018

Thank you!

@foosel
Copy link
Member Author

foosel commented Nov 13, 2018

1.3.10rc2 was just released.

@foosel foosel closed this as completed Nov 13, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@foosel foosel

Labels
bug Issue describes a bug done Done but not yet released
Projects
None yet
Milestone
1.3.10
Development

No branches or pull requests
2 participants
@foosel @ThaliaFP