Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel_extract doesn't work unless messages.pot already exists #2846

Closed
eyal0 opened this issue Oct 11, 2018 · 6 comments
Closed

babel_extract doesn't work unless messages.pot already exists #2846

eyal0 opened this issue Oct 11, 2018 · 6 comments
Labels
bug Issue describes a bug done Done but not yet released
Milestone

Comments

@eyal0
Copy link
Contributor

eyal0 commented Oct 11, 2018

What were you doing?

Running python setup.py babel_extract in my new plugin.

What did you expect to happen?

└──> octoprint dev plugin:new Test
plugin_package [octoprint_Test]: 
plugin_name [OctoPrint-Test]: 
repo_name [OctoPrint-Test]: 
full_name [You]: 
email [[email protected]]: 
github_username [you]: 
plugin_version [0.1.0]: 
plugin_description [TODO]: 
plugin_license [AGPLv3]: 
plugin_homepage [https://github.com/you/OctoPrint-Test]: 
plugin_source [https://github.com/you/OctoPrint-Test]: 
plugin_installurl [https://github.com/you/OctoPrint-Test/archive/master.zip]: 
└──> cd OctoPrint-Test 
└──> python setup.py babel_extract
Found packages: ['octoprint_Test']
running babel_extract
extracting messages from octoprint_Test/__init__.py
extracting messages from octoprint_Test/static/js/Test.js (extract_messages="gettext, ngettext")
writing PO template file to ./translations/messages.pot

What happened instead?

└──> octoprint dev plugin:new Test
plugin_package [octoprint_Test]: 
plugin_name [OctoPrint-Test]: 
repo_name [OctoPrint-Test]: 
full_name [You]: 
email [[email protected]]: 
github_username [you]: 
plugin_version [0.1.0]: 
plugin_description [TODO]: 
plugin_license [AGPLv3]: 
plugin_homepage [https://github.com/you/OctoPrint-Test]: 
plugin_source [https://github.com/you/OctoPrint-Test]: 
plugin_installurl [https://github.com/you/OctoPrint-Test/archive/master.zip]: 
└──> cd OctoPrint-Test 
└──> python setup.py babel_extract
Found packages: ['octoprint_Test']
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: setup.py --help [cmd1 cmd2 ...]
   or: setup.py --help-commands
   or: setup.py cmd --help

error: invalid command 'babel_extract'

Did the same happen when running OctoPrint in safe mode?

I was not running the OctoPrint server.

Version of OctoPrint

git commit 1ccc1fa

Operating System running OctoPrint

Linux

Printer model & used firmware incl. version

None

Browser and version of browser, operating system running browser

None

Link to octoprint.log

None

Link to contents of terminal tab or serial.log

None

Link to contents of Javascript console in the browser

None

Screenshot(s)/video(s) showing the problem:

Text above.

I have read the FAQ.

@ntoff
Copy link
Contributor

ntoff commented Oct 12, 2018

This isn't a bug in octoprint, if you need help developing plugins then please use the forum located at https://discourse.octoprint.org/

@eyal0
Copy link
Contributor Author

eyal0 commented Oct 12, 2018

It is a bug in octoprint that babel_extract requires that messages.pot exist first. Would you please look at the PR and reconsider?

@eyal0
Copy link
Contributor Author

eyal0 commented Oct 12, 2018

By the way, it's not octoprint for which I found the bug, it's the octoprint_setuptools. I looked at the discourse and found no mentions of babel_extract at all, so I think that it is a new issue. Maybe I am the only developer to have ever tried translating a plugin?

@foosel foosel added bug Issue describes a bug done Done but not yet released and removed triage This issue needs triage labels Oct 18, 2018
@foosel foosel added this to the 1.3.10 milestone Oct 18, 2018
@foosel
Copy link
Member

foosel commented Oct 18, 2018

Fixed by #2847 which was just merged to maintenance, soon devel and will be included in the 1.3.10 release.

@foosel
Copy link
Member

foosel commented Oct 18, 2018

Maybe I am the only developer to have ever tried translating a plugin?

Sadly only all too possible ;)

@foosel
Copy link
Member

foosel commented Dec 10, 2018

1.3.10 has been released.

@foosel foosel closed this as completed Dec 10, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue describes a bug done Done but not yet released
Projects
None yet
Development

No branches or pull requests

4 participants