Misleading terms "ordered/Bestellt" and "received/Bekommen"

[amigalemming]

In the PDF of an order we have the columns "Bestellt" and "Bekommen". I think they are pretty misleading and we had already some occassions where the processor of an order got that wrong. I think "Bestellt" should be phrased "Gewünscht" and "Bekommen" should be "Bestellt" instead. The problem is that "Bekommen" is not what we actually receive from the supplier. It is what we eventually order from the supplier. The quantity actually shipped by the supplier can again differ from what we ordered there.
Unfortunately the internal identifiers are also "ordered" and "received".

[yksflip]

hey!
thanks for this hint. I think you're right, this can be confusing!
I think it's phrased received/bekommen because one can actually change the numbers of item's that were actually delivered from the supplier in the receive-order flow. Or did I get you wrong here?

Nevertheless, changing the headlines in the pdf-view to something clearer would be a simple change.
Changing the variable names, would be a bigger refactoring.

[amigalemming]

On Wed, 28 Jun 2023, Philipp Rothmann wrote: I think it's phrased received/bekommen because one can actually change the numbers of item's that were actually delivered from the supplier in the receive-order flow. Or did I get you wrong here?

We first print the PDFs, then process the incoming delivery. At this point "Bekommen" equals the order at the supplier. Do the "Bekommen" numbers change if we alter the numbers in the "In Empfang nehmen" management? I think we do not use this feature, at all, because it cannot handle all the corner cases that actually occur.

[yksflip]

Yes! It should be updated. Also in the Matrix PDF is a Column called Gelieferte Gebinde

[twothreenine]

Thought: Should we make the headlines change with the state of the order?

To recap, order states are:

in code	English	German
open	open	laufend
finished	closed	beendet
received	received	in Empfang genommen
closed	settled	abgerechnet

You can skip the receive step.
Note that closed (in code) != closed (in frontend). This can be quite confusing!
Also, order.finished? will return true for received orders as well (code).

Back to the column headings:
I think there should be consistent terminology across all menus to avoid further confusion.
Currently "ordered" is used both as in "ordered by an ordergroup" as well as in "ordered from the supplier":
On the group order result page there's "ordered" (amount + tolerance of one's ordergroup -- change this to "desired"?) and "available" (considering orders of all groups). Meanwhile, in the receive menu, there's "desired" (amount + tolerance of all groups), ordered (from the supplier -- add "from supplier"?), and "received" (from the supplier - change this to "delivered"?).
Alternatively to "desired" / "gewünscht," we could also name it "to receive" / "zu bekommen."

In the order management menu and the PDFs, there's always "ordered" and "received." I think these should be:
open/closed/received order: desired / available (or "to receive")
settled order: desired / received
In PDFs downloaded from closed/received orders, I suggest adding an empty third column "received" to be filled out manually.

What do you think?

Note: This affects the article unit upgrade where we have to adapt the PDFs.

in the Matrix PDF is a Column called Gelieferte Gebinde

The translation is loose here. In English, it's "received units"