Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentype/STAT/ital_axis] Is reporting a FAIL on static fonts #4998

Open
guidoferreyra opened this issue Feb 25, 2025 · 0 comments
Open

[opentype/STAT/ital_axis] Is reporting a FAIL on static fonts #4998

guidoferreyra opened this issue Feb 25, 2025 · 0 comments

Comments

@guidoferreyra
Copy link
Contributor

Observed behaviour

When processing static fonts you get something like the following:

FAIL :
Font MyFont-Light.otf has no STAT table

FAIL :
Font MyFont-MediumItalic.otf has no STAT table

FAIL :
Font MyFont-Medium.otf has no STAT table

FAIL :
Font MyFont-LightItalic.otf has no STAT table

FAIL :
Font MyFont-Black.otf has no STAT table

I don’t think it should report this as a FAIL. AFAIK, static fonts can have STAT table but is not mandatory and, in fact, it looks like a bug since the code code tries to run the check only on a "vf_collection"

for roman, italic in segment_vf_collection(fonts):

In addition, the function to find roman and variable fonts relies on file names, I know the "source of truth" has been debated many times but limiting this just to the presence of "-Italic" in the filename it’s too limited to be on the Opentype profile. Font makers uses many different names for Italics and slanted designs.

https://github.com/fonttools/fontbakery/blob/4cc71b39c73f6eb7033d82bf413b6fe96c763c96/Lib/fontbakery/checks/opentype/STAT/ital_axis.py#L97C1-L103C37

Expected behaviour

Ommit static fonts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant