Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FontBakeryCheck:opentype/STAT/ital_axis] Relies on GF specific naming to test ital STAT axis in OpenType profile #4964

Open
benkiel opened this issue Jan 11, 2025 · 3 comments

Comments

@benkiel
Copy link
Contributor

benkiel commented Jan 11, 2025

(NOTE: Please include the check-id in the issue's title.)

Observed behaviour

Font that is italic, but not named the GF way, is classified as Roman by segment_vf_collection and gives an incorrect warnings for FontBakeryCheck:opentype/STAT/ital_axis

Expected behaviour

Fontbakery uses the is_italic test to classify fonts correctly

Resources and steps needed to reproduce

Any variable font that has an ital axis but doesn't conform to the GF naming of having -Italic[ in the file name will get classified as Roman, and trigger the incorrect report.

@benkiel benkiel changed the title [FontBakeryCheck:opentype/STAT/ital_axis] Relies on GF specific naming to test ital STAT axis in Universal profile [FontBakeryCheck:opentype/STAT/ital_axis] Relies on GF specific naming to test ital STAT axis in OpenType profile Jan 11, 2025
@felipesanches felipesanches self-assigned this Jan 11, 2025
@felipesanches
Copy link
Collaborator

Thanks for reporting this!

@benkiel
Copy link
Contributor Author

benkiel commented Jan 13, 2025

@felipesanches, the above is a start; feel free to pick it up if you want. I think mostly complete

@felipesanches
Copy link
Collaborator

This is similar to #4971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants