diff --git a/Lib/fontbakery/checks/render_own_name.py b/Lib/fontbakery/checks/vendorspecific/googlefonts/render_own_name.py similarity index 96% rename from Lib/fontbakery/checks/render_own_name.py rename to Lib/fontbakery/checks/vendorspecific/googlefonts/render_own_name.py index 9c78088d55..73d07da59c 100644 --- a/Lib/fontbakery/checks/render_own_name.py +++ b/Lib/fontbakery/checks/vendorspecific/googlefonts/render_own_name.py @@ -9,7 +9,7 @@ @check( - id="render_own_name", + id="googlefonts/render_own_name", rationale=""" A base expectation is that a font family's regular/default (400 roman) style can render its 'menu name' (nameID 1) in itself. diff --git a/Lib/fontbakery/legacy_checkids.py b/Lib/fontbakery/legacy_checkids.py index 1ccea78df6..a6d07eea87 100644 --- a/Lib/fontbakery/legacy_checkids.py +++ b/Lib/fontbakery/legacy_checkids.py @@ -130,6 +130,7 @@ "com.google.fonts/check/old_ttfautohint": "googlefonts/old_ttfautohint", "com.google.fonts/check/production_encoded_glyphs": "googlefonts/production_encoded_glyphs", "com.google.fonts/check/production_glyphs_similarity": "googlefonts/production_glyphs_similarity", + "com.google.fonts/check/render_own_name": "googlefonts/render_own_name", "com.google.fonts/check/repo/dirname_matches_nameid_1": "googlefonts/repo/dirname_matches_nameid_1", "com.google.fonts/check/repo/fb_report": "googlefonts/repo/fb_report", "com.google.fonts/check/repo/sample_image": "googlefonts/repo/sample_image", @@ -273,7 +274,6 @@ "com.google.fonts/check/outline_jaggy_segments": "outline_jaggy_segments", "com.google.fonts/check/outline_semi_vertical": "outline_semi_vertical", "com.google.fonts/check/outline_short_segments": "outline_short_segments", - "com.google.fonts/check/render_own_name": "render_own_name", "com.google.fonts/check/required_tables": "required_tables", "com.google.fonts/check/rupee": "rupee", "com.adobe.fonts/check/sfnt_version": "sfnt_version", diff --git a/Lib/fontbakery/profiles/adobefonts.py b/Lib/fontbakery/profiles/adobefonts.py index fc64da11e7..1a6eb588de 100644 --- a/Lib/fontbakery/profiles/adobefonts.py +++ b/Lib/fontbakery/profiles/adobefonts.py @@ -68,7 +68,6 @@ "no_debugging_tables", "no_mac_entries", "overlapping_path_segments", - "render_own_name", "smallcaps_before_ligatures", "smart_dropout", "soft_hyphen", diff --git a/Lib/fontbakery/profiles/fontbureau.py b/Lib/fontbakery/profiles/fontbureau.py index ac0448c726..276598714d 100644 --- a/Lib/fontbakery/profiles/fontbureau.py +++ b/Lib/fontbakery/profiles/fontbureau.py @@ -25,7 +25,6 @@ "nested_components", "no_mac_entries", "overlapping_path_segments", - "render_own_name", "smart_dropout", "stylisticset_description", "typographic_family_name", diff --git a/Lib/fontbakery/profiles/googlefonts.py b/Lib/fontbakery/profiles/googlefonts.py index 19551f5838..a93a6df076 100644 --- a/Lib/fontbakery/profiles/googlefonts.py +++ b/Lib/fontbakery/profiles/googlefonts.py @@ -138,6 +138,7 @@ "googlefonts/old_ttfautohint", "googlefonts/production_glyphs_similarity", # "googlefonts/production_encoded_glyphs", # DISABLED + "googlefonts/render_own_name", "googlefonts/STAT/axis_order", "googlefonts/STAT/axisregistry", "googlefonts/STAT/compulsory_axis_values", diff --git a/Lib/fontbakery/profiles/microsoft.py b/Lib/fontbakery/profiles/microsoft.py index 9d7bdab1cb..96cb87f20c 100644 --- a/Lib/fontbakery/profiles/microsoft.py +++ b/Lib/fontbakery/profiles/microsoft.py @@ -38,7 +38,6 @@ "no_debugging_tables", "no_mac_entries", "overlapping_path_segments", - "render_own_name", "smallcaps_before_ligatures", "smart_dropout", "stylisticset_description", diff --git a/Lib/fontbakery/profiles/notofonts.py b/Lib/fontbakery/profiles/notofonts.py index 1368e3781e..b60dd00135 100644 --- a/Lib/fontbakery/profiles/notofonts.py +++ b/Lib/fontbakery/profiles/notofonts.py @@ -26,8 +26,8 @@ "exclude_checks": [ "googlefonts/glyph_coverage", "googlefonts/gasp", + "googlefonts/render_own_name", # - "render_own_name", "smart_dropout", ], "configuration_defaults": { diff --git a/Lib/fontbakery/profiles/typenetwork.py b/Lib/fontbakery/profiles/typenetwork.py index 2219569750..49507b2c76 100644 --- a/Lib/fontbakery/profiles/typenetwork.py +++ b/Lib/fontbakery/profiles/typenetwork.py @@ -27,7 +27,6 @@ "math_signs_width", # It really depends on the design and the intended use to make math symbols the same width. "name/no_copyright_on_description", "os2_metrics_match_hhea", # Removed in favor of new vmetrics check - "render_own_name", "STAT_strings", # replaced by adobefonts/STAT_strings "superfamily/list", "ufolint", # < TypeNetwork doesn’t check .ufo files. diff --git a/Lib/fontbakery/profiles/universal.py b/Lib/fontbakery/profiles/universal.py index 3432b76357..fcddae0079 100644 --- a/Lib/fontbakery/profiles/universal.py +++ b/Lib/fontbakery/profiles/universal.py @@ -68,7 +68,6 @@ "ots", "overlapping_path_segments", "required_tables", - "render_own_name", "rupee", "sfnt_version", "smallcaps_before_ligatures", diff --git a/tests/test_checks_glyphset.py b/tests/test_checks_glyphset.py index d37609e604..2e4cc87aef 100644 --- a/tests/test_checks_glyphset.py +++ b/tests/test_checks_glyphset.py @@ -19,17 +19,6 @@ def test_can_shape(): assert not can_shape(font, "こんにちは") -@check_id("render_own_name") -def test_check_render_own_name(check): - """Check family directory name.""" - - ttFont = TEST_FILE("overpassmono/OverpassMono-Regular.ttf") - assert_PASS(check(ttFont)) - - ttFont = TEST_FILE("noto_sans_tamil_supplement/NotoSansTamilSupplement-Regular.ttf") - assert_results_contain(check(ttFont), FAIL, "render-own-name") - - @check_id("control_chars") def test_check_family_control_chars(check): """Are any unacceptable control characters present in font files?""" diff --git a/tests/test_checks_googlefonts_render_own_name.py b/tests/test_checks_googlefonts_render_own_name.py new file mode 100644 index 0000000000..3f0351b17c --- /dev/null +++ b/tests/test_checks_googlefonts_render_own_name.py @@ -0,0 +1,18 @@ +from conftest import check_id +from fontbakery.codetesting import ( + assert_PASS, + assert_results_contain, + TEST_FILE, +) +from fontbakery.status import FAIL + + +@check_id("googlefonts/render_own_name") +def test_check_render_own_name(check): + """Check family directory name.""" + + ttFont = TEST_FILE("overpassmono/OverpassMono-Regular.ttf") + assert_PASS(check(ttFont)) + + ttFont = TEST_FILE("noto_sans_tamil_supplement/NotoSansTamilSupplement-Regular.ttf") + assert_results_contain(check(ttFont), FAIL, "render-own-name")