Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cells not rendering properly on Android via github #785

Closed
klaff opened this issue Dec 17, 2020 · 7 comments
Closed

code cells not rendering properly on Android via github #785

klaff opened this issue Dec 17, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request frontend Concerning the HTML editor

Comments

@klaff
Copy link

klaff commented Dec 17, 2020

The bottom line of a code cell is being cut off when viewed in Chrome or Firefox on Android.

See https://klaff.github.io/android_display_bug_MWE.html for simple test page.

@pankgeorg
Copy link
Collaborator

So, the problem here is that the div.CodeMirror-sizer is supposed to have its inline styles adjusted by javascript. That obviously doesn't happen in the static version.

The thing is, CodeMirror says they're experimental on mobile browsers, which is weird.
from https://codemirror.net/

I'll try to sketch something up but - to set expectations - it may be difficult to work for any case.

@klaff
Copy link
Author

klaff commented Dec 23, 2020

A not-too-obnoxious workaround is to include a blank line at the end of each code cell. I updated my MWE above to have a cell without and a cell with the extra line.

P. S. Καλά Χριστούγεννα!

@pankgeorg
Copy link
Collaborator

Well, I've opened a PR #805 with a possible solution (loads CodeMirror in again in the export to do the height management correctly)

Happy holidays!

@fonsp
Copy link
Owner

fonsp commented Jan 18, 2021

linked to #823

@fonsp fonsp added the frontend Concerning the HTML editor label Jan 18, 2021
@fonsp fonsp self-assigned this Jan 18, 2021
@fonsp fonsp added the enhancement New feature or request label Jan 18, 2021
@pankgeorg
Copy link
Collaborator

@fonsp for the HTML export part, this PR exists #805.
If we go another way we should close it!

@pankgeorg
Copy link
Collaborator

also seems to handle the linked issue (823)

@fonsp
Copy link
Owner

fonsp commented Jan 26, 2021

Fixed by the wonderful @pankgeorg !!!! Will be released in the next version

@fonsp fonsp closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Concerning the HTML editor
Projects
None yet
Development

No branches or pull requests

3 participants