Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live docs - include prefixed module in search term #239

Closed
staticfloat opened this issue Jul 30, 2020 · 10 comments
Closed

Live docs - include prefixed module in search term #239

staticfloat opened this issue Jul 30, 2020 · 10 comments
Assignees
Labels
almost closed frontend Concerning the HTML editor
Milestone

Comments

@staticfloat
Copy link

staticfloat commented Jul 30, 2020

I tried to get the live docs for CSV.File, as shown in the excellent JuliaCon 2020 talk, but unfortunately, it doesn't work for me:

image

This is running Pluto v0.11.1 on Julia 1.4.2 on macOS.

@fonsp
Copy link
Owner

fonsp commented Jul 30, 2020

Yeah you have to select (with your mouse) the whole expression CSV.File, if the cursor is on top of File, it will only search for that. But let's fix that!

@fonsp fonsp changed the title Live docs not working for example used in JuliaCon talk Live docs - include prefixed module in search term Jul 30, 2020
@staticfloat
Copy link
Author

Hmmm, that doesn't seem to be working for me either:

image

@fonsp
Copy link
Owner

fonsp commented Jul 30, 2020

Thanks! I'll look into it

@fonsp
Copy link
Owner

fonsp commented Jul 30, 2020

Also write to #111 if you have suggestions!

@fonsp fonsp self-assigned this Aug 2, 2020
@fonsp fonsp added the bug Something isn't working label Aug 2, 2020
@fonsp fonsp added this to the 🧭 v0.12 milestone Aug 12, 2020
@fonsp fonsp closed this as completed in 7be3b55 Aug 30, 2020
@fonsp
Copy link
Owner

fonsp commented Aug 30, 2020

Fixed! Will be released soon

sorry it took a while :)

@fonsp
Copy link
Owner

fonsp commented Aug 30, 2020

@mapclyps
Copy link

For me the original issue is still there in Pluto 0.11.10.

I think it is when the function is not exported, the documentation is not showing up. As in the CSV.File in the original issue where File is not exported. The test passes since Base.sqrt is exported as sqrt

@fonsp fonsp reopened this Sep 1, 2020
@fonsp
Copy link
Owner

fonsp commented Sep 1, 2020

Aha, it works, but you need to select the whole phrase CSV.File. If you place your cursor at File, then it will only search for File.

But this should be detected

@fonsp fonsp added frontend Concerning the HTML editor and removed bug Something isn't working labels Sep 1, 2020
@mapclyps
Copy link

mapclyps commented Sep 1, 2020

Aha, it works, but you need to select the whole phrase CSV.File. If you place your cursor at File, then it will only search for File.

But this should be detected

Oh yes it works indeed with selecting the whole expression. I should have tried that.
Recognition of the dot syntax for the live docs display would be really nice!

@fonsp fonsp added good first issue Good for newcomers help welcome If you are experienced in this topic - let us know! almost closed and removed good first issue Good for newcomers help welcome If you are experienced in this topic - let us know! labels Sep 12, 2020
@fonsp fonsp closed this as completed in 63e400d Sep 13, 2020
@fonsp
Copy link
Owner

fonsp commented Sep 13, 2020

It now detects the prefixed module while typing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
almost closed frontend Concerning the HTML editor
Projects
None yet
Development

No branches or pull requests

3 participants