Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell drag and drop broken triggers PNG file upload #1684

Closed
j-fu opened this issue Nov 23, 2021 · 6 comments · Fixed by #1780
Closed

Cell drag and drop broken triggers PNG file upload #1684

j-fu opened this issue Nov 23, 2021 · 6 comments · Fixed by #1780
Labels
bug Something isn't working frontend Concerning the HTML editor

Comments

@j-fu
Copy link
Contributor

j-fu commented Nov 23, 2021

Hi, with the new release, instead of the moved cell, Pluto inserts something like this:

png_joinpathsplit__FILE__1assets1_q8s7EQC6INcqCHZELbVIDA6png = let
    import PlutoUI
    PlutoUI.LocalResource(joinpath(split(@__FILE__, '#')[1] * ".assets", "1_q8s7EQC6INcqCHZELbVIDA 6.png"))
end

The cell to be moved remains on its place. Couriously, on Firefox this problem does not occur.

@fonsp fonsp added bug Something isn't working frontend Concerning the HTML editor labels Nov 27, 2021
@jcanizales
Copy link

Maybe Chrome isn't implementing the API as per the spec this relies on https://github.com/fonsp/Pluto.jl/pull/977/files ? The original "don't do it if dragging started inside the notebook" wording might be the best solution.

@jcanizales
Copy link

FWIW, I'm seeing this on Pluto 0.16.0, Chrome 96.

@fonsp
Copy link
Owner

fonsp commented Dec 22, 2021

Can you try out #1780 to see if that fixes the problem?

@fonsp fonsp linked a pull request Dec 22, 2021 that will close this issue
@j-fu
Copy link
Contributor Author

j-fu commented Jan 7, 2022

Hi, ... well it seem that this again is not working - my suspicion is chrome v97, because the fix in #1780 ceased to work, and so it doesn't work in 0.17.5 as well. I also tried Pluto 0.16.1 for double checking - the same.

@j-fu j-fu changed the title Cell drag and drop broken in 0.17.2 (linux/chrome) Cell drag and drop broken in chrome 97 Jan 7, 2022
@fonsp
Copy link
Owner

fonsp commented Jan 7, 2022

Let's make a new issue (so that it feels like we fixed something 🙃)

@fonsp fonsp changed the title Cell drag and drop broken in chrome 97 Cell drag and drop broken triggers PNG file upload Jan 7, 2022
@fonsp
Copy link
Owner

fonsp commented Jan 19, 2022

Moved to #1809

Repository owner locked and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants