Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment] A basic segment within .segments should be basic #233

Closed
lubber-de opened this issue Nov 2, 2018 · 1 comment
Closed

[Segment] A basic segment within .segments should be basic #233

lubber-de opened this issue Nov 2, 2018 · 1 comment
Assignees
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/feat Any feature requests or improvements

Comments

@lubber-de
Copy link
Member

Feature Request

Description

This PR try to fix a problem and add a new functionality :

  • The fix : when we have a .ui.basic.segment inside of .ui.horizontal.segments, the basic segment doesn't loose the border and shadow.
  • The new functionality : Add a .ui.basic.segments with s
    It comes in handy when we want to do something like this
.ui.horizontal.basic.segments>(.ui.basic.segment+.ui.basic.right.aligned.segment)

Edit: This is an example from my app

Before the PR
Jsfiddle example : https://jsfiddle.net/h4nycLoj/
image

After the PR

image

The markup used in the images

<div class="ui horizontal basic segments"> <!-- New functionality -->
    <div class="ui basic segment"> ... </div><!-- Fixed: basic segment shouldn't have borders -->

    <div class="ui basic right aligned segment"> ... </div><!-- Fixed: basic segment shouldn't have borders -->
</div>

Original SUI PR

Semantic-Org/Semantic-UI#4773

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI labels Nov 2, 2018
@prudho prudho self-assigned this Nov 5, 2018
@prudho
Copy link
Contributor

prudho commented Nov 5, 2018

This is already fixed in #32 (original issue was Semantic-Org/Semantic-UI#3801).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/feat Any feature requests or improvements
Projects
None yet
Development

No branches or pull requests

2 participants