Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: cmdline_popup view is not compatible with mini.align plugin #346

Closed
3 tasks done
Fau818 opened this issue Feb 1, 2023 · 4 comments
Closed
3 tasks done

bug: cmdline_popup view is not compatible with mini.align plugin #346

Fau818 opened this issue Feb 1, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@Fau818
Copy link

Fau818 commented Feb 1, 2023

Did you check docs and existing issues?

  • I have read all the noice.nvim docs
  • I have searched the existing issues of noice.nvim
  • I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.8.2

Operating system/version

MacOS 13.2

Describe the bug

I use mini.align plugin to align my code, but it does not display the characters when I enter the Split Pattern(mini.align) via cmdline_popup view. However, it works if I use hover view.

We can see it in the following video.

Noice.mov

Steps To Reproduce

Shown in the above video.

Expected Behavior

I can see the entered text in real time for cmdline_popup view, just like in the hover view.

Repro

No response

@Fau818 Fau818 added the bug Something isn't working label Feb 1, 2023
@Fau818
Copy link
Author

Fau818 commented Feb 2, 2023

I've figured out the reason, I need to set enter = true manually.

Thanks for providing such a great plugin!

@Fau818 Fau818 closed this as completed Feb 2, 2023
@Fau818
Copy link
Author

Fau818 commented Feb 2, 2023

Sorry, I still found some problems, and I've to reopen this.

If I don't set enter = true and use the adaptive size, it can display the entered text in real time.

Example from noice.config.views

hover = {
	view = "popup",
	relative = "cursor",
	zindex = 45,
	enter = false,
	anchor = "auto",
	size = {  -- important
		width = "auto",
		height = "auto",
		max_height = 20,
		max_width = 120,
	},
	border = {
		style = "rounded",
		padding = { 0, 1 },
	},
	position = { row = 1, col = 0 },
	win_options = {
		wrap = true,
		linebreak = false,
	},
},

But if I use a fixed size, it can't display the entered text in real time.

For example, use the following code to replace the size part.

size = {
	width = 60,
	height = "auto"
}

Is it possible to display the entered text in real time even at a fixed size?

@folke
Copy link
Owner

folke commented Feb 6, 2023

This should be fixed now. Let me know if the problem would still perssist with the latest version!

@folke folke closed this as completed Feb 6, 2023
@farzadmf
Copy link

farzadmf commented Feb 6, 2023

Tried with the latest version, and it's working

Once, it stopped typing characters once I entered a couple, but I'm hoping that was a one-off thing. Will update here if I see an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants