Fixed cmdline_force_redraw hack for path completion #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the report! I've changed it to check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #188. The hack was doing stuff to make sure the screen is redrawn when typing a substitution command, but
s/also matches every path with a directory with ansat the end. For the user, it looks like every path with ansat the end is automatically accepted (see the bug report). I Changed the hack to first check for ans/and if there is one, check that the current command is not a command that could use path completion.A better way would probably be to check if the completion pop-up is currently open, but I don't know how to do that and this works.