fix(luarocks): try to install from root manifest #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This PR is stale because it has been open 30 days with no activity. |
|
not stale |
|
ty! |
folke
pushed a commit
that referenced
this pull request
Nov 11, 2024
🤖 I have created a release *beep* *boop* --- ## [11.14.2](v11.14.1...v11.14.2) (2024-11-10) ### Bug Fixes * **bootstrap:** single forward slash. Fixes [#1747](#1747) ([aca30f6](aca30f6)) * **completion:** check if command string is a prefix of Lazy ([#1760](#1760)) ([e9fd76e](e9fd76e)), closes [#1758](#1758) * **docs:** always update helptags for local plugins ([60cf258](60cf258)) * **luarocks:** try to install from root manifest ([#1687](#1687)) ([591ef40](591ef40)) * **rocks:** add lib64 plugin directory to package.cpath ([#1717](#1717)) ([80da254](80da254)) * **rockspec:** allow binary lua files. Fixes [#1800](#1800) ([408449a](408449a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When passing the
--devflag toluarocks, it will prioritisedevversions when resolving dependencies (treatingdevorscmas greater than a SemVer version) if the rockspec doesn't specify an upper version constraint (which is often the case).Dev packages are often unstable and may cause more problems, especially for Windows users (an example I've seen is git for windows trying and failing to checkout submodules).
For now , a good compromise between too many retries and not retrying at all could be to try
luarocks installfrom the root manifest first, but to keep the--devflag inluarocks make.If that still causes problems, it might be better to fall back to
luarocks makewithout--devfirst, and then to tryluarocks ---dev makeas a last resort.In rocks.nvim, we only fall back to adding the
--devflag if the install error message contains the string"No results matching query were found"; assuming that stable non-dev packages shouldn't depend on dev packages.