Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when removing a plugin #16

Closed
tsakirist opened this issue Dec 20, 2022 · 7 comments · Fixed by #17
Closed

Error when removing a plugin #16

tsakirist opened this issue Dec 20, 2022 · 7 comments · Fixed by #17
Labels
bug Something isn't working

Comments

@tsakirist
Copy link
Contributor

tsakirist commented Dec 20, 2022

Describe the bug
Pressing x to remove an installed plugin throws an error, but the operation succeeds.

Which version of Neovim are you using?
NVIM v0.9.0-dev-519+g2d8bbe468 nightly

To Reproduce
Steps to reproduce the behavior:

  1. Install a plugin
  2. Open :Lazy
  3. Find the plugin move cursor on top of the plugin's name and press x

Expected Behavior
The plugin should be just deleted, no errors.

Screenshots
Screenshot from 2022-12-20 12-52-57

@tsakirist tsakirist added the bug Something isn't working label Dec 20, 2022
@folke folke closed this as completed in ae644a6 Dec 20, 2022
@folke
Copy link
Owner

folke commented Dec 20, 2022

Thank you for reporting. Fixed!

@tsakirist
Copy link
Contributor Author

Trying to remove a plugin now causes another error just pressed Clean (X) but pressing x on individual plugins produces the same error:

Screenshot from 2022-12-20 14-13-09

@folke folke reopened this Dec 20, 2022
@folke
Copy link
Owner

folke commented Dec 20, 2022

That error means you have a plugin name twice with a different short url.

I just pushed a change that shows a detailed error and continues with the other specs.

I'm also not able to reproduce, so would be great if you can give detailed steps in case the new error message is not helpful.

@tsakirist
Copy link
Contributor Author

That error means you have a plugin name twice with a different short url.

I just pushed a change that shows a detailed error and continues with the other specs.

I'm also not able to reproduce, so would be great if you can give detailed steps in case the new error message is not helpful.

So basically the problem appears when I have a plugin as a dependency of another, but have that plugin installed standalone.
For instance something like this:

return require("lazy").setup {
	{ "kyazdani42/nvim-web-devicons" },
	{
		"hoob3rt/lualine.nvim",
		event = "BufRead",
		dependencies = {
			"kyazdani42/nvim-web-devicons",
			"SmiteshP/nvim-navic",
		},
		config = function()
			require("tt.themes.lualine").setup()
		end,
	},

@folke
Copy link
Owner

folke commented Dec 20, 2022

Can't reproduce it that way. That repo recently changed its name to nvim-tree/nvim-web-devicons.

Are you sure you are not using a different url in both places?

That would trigger an error whcih is to be expected

@folke
Copy link
Owner

folke commented Dec 20, 2022

Never mind, can reproduce it. will see to fix this.

@folke
Copy link
Owner

folke commented Dec 20, 2022

Should be fixed now!

@folke folke closed this as completed Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants