Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Change detection is broken on v11+ #1567

Closed
3 tasks done
julienvincent opened this issue Jun 26, 2024 · 2 comments · Fixed by #1565
Closed
3 tasks done

bug: Change detection is broken on v11+ #1567

julienvincent opened this issue Jun 26, 2024 · 2 comments · Fixed by #1565
Labels
bug Something isn't working

Comments

@julienvincent
Copy link

Did you check docs and existing issues?

  • I have read all the lazy.nvim docs
  • I have searched the existing issues of lazy.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.9.5

Operating system/version

MacOS 14.3

Describe the bug

I have change_detection.enabled = false defined in my config:

require("lazy").setup({
  spec = {
    ...
  },
  change_detection = {
    enabled = false,
  },
  ...
})

Which works as expected on v10.24.3 - the version of lazy I am currently running. After upgrading to any version of lazy.nvim after v11 saving a file in my lua config will print notifications in neovim.

See attached image:
image

Steps To Reproduce

  1. Upgrade to lazy.nvim v11+
  2. Run :w in a file in your neovim config directory

Expected Behavior

Change detection should be disabled when change_detection.enabled = false

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here
@julienvincent julienvincent added the bug Something isn't working label Jun 26, 2024
@folke folke closed this as completed in 24a86d5 Jun 27, 2024
@dhananjaylatkar
Copy link

@julienvincent

is this working for you? I'm still seeing same issue

@julienvincent
Copy link
Author

Yes works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants