fix: don't check updates for local plugins #1512
Conversation
|
I find it quite useful to see if any of my local plugins have new commits on the same branch remotely. I just changed it so that only in that case it will show updates. |
🤖 I have created a release *beep* *boop* --- ## [11.10.2](v11.10.1...v11.10.2) (2024-07-07) ### Bug Fixes * **git:** only check for new commits for local plugins. Closes [#1512](#1512) ([81d2bff](81d2bff)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@folke 81d2bff certainly fixes the main issue, and being able to see if there are updates on the remote branch is indeed useful. I am however still seeing some dev plugins shown as having updates available with an empty list of available updates. I would expect the list of updates for a plugin to be essentially the results of From what I can tell, the check being done for whether updates are required is just whether the local and upstream commit hashes are different. This makes sense for non-local plugins, because you always want local equal to upstream. But for a local plugin, I'd argue that having local and upstream be different is perfectly fine, as long as local is not behind upstream. |
## Description As I described in #1512 (comment), this makes it so that local plugins will only show as needing updates if the local branch is behind the upstream branch. This is done by checking the output of the `git log` command, and only setting `plugin._.updates` if the output is not empty. This seems to solve my issue where local plugins with unpushed changes always show as needing updates, but if there's a easier/better way of doing it then please feel free to edit/close this. Or if you don't agree that the current behaviour is a bug, then that's also fine - it's not a big deal and I can easily just ignore the "updates available" notice. I also came across a minor issue where the plugin diff view (press `d`) compares the wrong commits for local plugins, because [lua/lazy/view/init.lua](https://github.com/folke/lazy.nvim/blob/c771cf4928d1a1428ac7461658ab2916ed48adf5/lua/lazy/view/init.lua#L268) always uses `get_target`. I fixed this by moving `get_local_target` into `get_target` - I think this is simpler and more straightforward than the alternative of adding a ternary everywhere `get_target` is called. This second bugfix is a very small change, so I've just included it here, but I'm happy to make a second PR if you'd like. ## Related Issue(s) Related PR: #1512
Extends #1384 to cover all local plugins, not just dev ones. Also adds a skip condition for local plugins to the
git.logtask - without this, a local plugin that is on a different branch to that specified in the spec always shows as needing updates.