UICAL-152: Fix calendar exceptions displaying on wrong day of week (offset by a day) #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Stanislau-Snapok
approved these changes
Sep 1, 2021
annamelnyk
approved these changes
Sep 2, 2021
zburke
reviewed
Sep 2, 2021
zburke
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Day of work and exceptions displaying on wrong day of week
Approach
We have some problem in react-big-calendar with timezone (Moves everything over a day) more details in
jquense/react-big-calendar#118 ,
jquense/react-big-calendar#809 and etc.
How you can see for timezone 0 and bigger work correctly (Screenshot section). Current bug reproducible only for timezone less than 0. This is problem with "react-big-calendar" all the days shifts over by 1 and this is workaround for resolve problem with "react-big-calendar". For resolve current problem we use accessor and offset hours.
Stories
https://issues.folio.org/browse/UICAL-152
https://issues.folio.org/browse/UICAL-157
Screenshot
Before changes (example with deferent timezone)
UTC+2
UTC -1
UTC -12
shifted days for timezone less than 0
After changes