From 4d7c7503debc94fedd81a8c12aefa9984bbd75c0 Mon Sep 17 00:00:00 2001 From: Mario Mol Date: Thu, 4 Apr 2019 09:16:45 -0300 Subject: [PATCH 1/3] Update v4.rb --- lib/fog/ovirt/compute/v4.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fog/ovirt/compute/v4.rb b/lib/fog/ovirt/compute/v4.rb index e560309..63f6fce 100644 --- a/lib/fog/ovirt/compute/v4.rb +++ b/lib/fog/ovirt/compute/v4.rb @@ -190,7 +190,7 @@ def blank_template @blank_template ||= client.system_service.get.special_objects.blank_template end - def create_search_by_datacenter(search:, datacenter:, page: nil) + def create_search_by_datacenter(search: nil, datacenter: nil, page: nil) search ||= "" search += " datacenter=#{datacenter}" if datacenter search += " page #{page}" if page From a1305d062d5f69a17980dbe2ace966a28dbeb86b Mon Sep 17 00:00:00 2001 From: Mario Mol Date: Fri, 11 Oct 2019 11:02:10 -0300 Subject: [PATCH 2/3] Update v4.rb guard conditions for create_search_by_datacenter --- lib/fog/ovirt/compute/v4.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/fog/ovirt/compute/v4.rb b/lib/fog/ovirt/compute/v4.rb index 63f6fce..25fad95 100644 --- a/lib/fog/ovirt/compute/v4.rb +++ b/lib/fog/ovirt/compute/v4.rb @@ -191,6 +191,7 @@ def blank_template end def create_search_by_datacenter(search: nil, datacenter: nil, page: nil) + unless datacenter raise ::Fog::Ovirt::Errors::OvirtEngineError('Cannot create search request by datacenter, when datacenter is nil`) search ||= "" search += " datacenter=#{datacenter}" if datacenter search += " page #{page}" if page From 210b9940219ba0c1c4bb32c1d9684c5a190ba931 Mon Sep 17 00:00:00 2001 From: Mario Mol Date: Mon, 17 Aug 2020 19:28:02 -0300 Subject: [PATCH 3/3] Update lib/fog/ovirt/compute/v4.rb Co-authored-by: Shira Maximov --- lib/fog/ovirt/compute/v4.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fog/ovirt/compute/v4.rb b/lib/fog/ovirt/compute/v4.rb index 25fad95..1e7e3a5 100644 --- a/lib/fog/ovirt/compute/v4.rb +++ b/lib/fog/ovirt/compute/v4.rb @@ -191,7 +191,7 @@ def blank_template end def create_search_by_datacenter(search: nil, datacenter: nil, page: nil) - unless datacenter raise ::Fog::Ovirt::Errors::OvirtEngineError('Cannot create search request by datacenter, when datacenter is nil`) + unless datacenter raise ::Fog::Ovirt::Errors::OvirtEngineError('Cannot create search request by datacenter, when datacenter is nil') search ||= "" search += " datacenter=#{datacenter}" if datacenter search += " page #{page}" if page