-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style component theme #26
Comments
@fobbyal BasicColHeader appears to be the parent component that is extended by different components. ColHeader for flexRenderer & ColHeaderBase for virtualized. In case of virtualizedRender, I also see Provider component that wraps the entire grid. The structure appears in place to provide default header config through this component. Let me know your thoughts on above analysis. |
@fraindz You are correct about the analysis. There are places in both flexRender and virtualizedRender to supply custom render functions for the Headers. However that requires the implementation of the whole render, we often just want some styling changed. Our goal here is to have a Provider that is available to code that are rendering the grid so the styling can be controlled from outside of this library. please see the storybook example at grid-tools/src/stories/flex/flex.stories.js Lines 69 to 83 in 64ef1f2
By specifying the |
@fobbyal That helps. I will make changes and create PR. |
Project Background
This is a project that utilized react-virtualized, downshft,react-popper to create a excel-like react component. ( without the function stuff)
Environment
Specification
Header styles are currently hardcoded. We want to make it so that we can customize the header render first.
We want to make it customizable via Context Api. This project currently does support hooks feel free to use
useContext
. Utilize existing src/context.js to handle theme based states.Grid Renders
We currently support 2 types of grids that are rendered by
src/flexRender.js
andvirtualized/virtualizedRenderer.js
. Theses are demoed by the following storybook links respectively. We need the style theme to work for both type of renders.The text was updated successfully, but these errors were encountered: