Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dependencies #60

Closed
bdavid68 opened this issue Dec 8, 2018 · 1 comment
Closed

Cleanup dependencies #60

bdavid68 opened this issue Dec 8, 2018 · 1 comment

Comments

@bdavid68
Copy link

bdavid68 commented Dec 8, 2018 •
edited
Loading

First of all, thanks for sharing a nice library.
Can you please cleanup the dependencies and devDependencies?
Especially, react-navigation. Actually, this library doesn't depend on the navigation lib.
So while we are using another navigation lib, it becomes to be spam package.
I hope you to cleanup the dependencies to install only necessary packages.
Thanks in advance.
@jeremy-farnault
Copy link
Contributor

Hi,

I removed the react-navigation dependency. It's the only one that I can see that's not used.
Thanks for that :)

Cheers,
Jeremy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremy-farnault @bdavid68