handleResultEnterPin changed to handleResult

[tkulpa]

Nothing in docs, and getting ts error while trying to pass handleResult (incorrect types I guess)

[jeremy-farnault]

Hi,

I don't know what you're talking about tbh. :)

This is the index.tsx:

https://github.com/fnzc/react-native-pincode/blob/5001c5b36b99ac71897a951cb822df7376938087/index.tsx#L21

The index.d.ts:

https://github.com/fnzc/react-native-pincode/blob/5001c5b36b99ac71897a951cb822df7376938087/dist/index.d.ts#L16

And the index.js:

https://github.com/fnzc/react-native-pincode/blob/5001c5b36b99ac71897a951cb822df7376938087/dist/index.js#L51

I just tried it and I can't use handleResult, just handleResultEnterPin.

Cheers,
Jeremy

[jeremy-farnault]

But what would you use this directly?
The name is changed inside the component for convenience but if you invoque the PINCode as stated in the doc through the status property it’s working as it should.

Cheers,
Jeremy

[tkulpa]

@Haskkor Hey Jeremy, I mean after update Im having issue with handling pin on my own, Im getting this error, and still didnt track sources for that, I checked code and thought that this could be reason
https://github.com/fnzc/react-native-pincode/blob/master/src/PinCodeEnter.tsx#L135
But shouldnt get there in first place as Im providing my own handler
https://github.com/fnzc/react-native-pincode/blob/master/src/PinCodeEnter.tsx#L126

And this issue wasn't a case in version 1.10.0, and Ill add that I dont want to use keychain with your component, just handle all on my own thats why Im overwriting handleResultEnterPin, finishProcess, storePin and onFail

[jeremy-farnault]

Hi :)

If you use storePin to handle the pin on your own, are you using storedPin property as well to provide the PIN to the component?
If not, I guess it'll crash because storedPin is undefined and nothing was stored in the keychain.
I found a bug with the keychain anyway looking at your issue and will release a new version today but I don't think it's related.

Cheers,
Jeremy

[tkulpa]

@Haskkor Im not using storedPin as Im not storing pin, Im encrypting data and then trying to decrypt it with pin user inputted, if it fails I know that pin was incorrect otherwise all good. So I dont need to store pin at all

[jeremy-farnault]

Hi,

Sorry for the misunderstanding :).
I tried to fix this without breaking the other things I've fixed/added lately.
Please test version 1.10.6 and tell me :).

Cheers,
Jeremy

[tkulpa]

Hey, great job! Everything is working as expected