Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cask is not configured #39

Closed
R0dri opened this issue Oct 31, 2019 · 5 comments
Closed

Cask is not configured #39

R0dri opened this issue Oct 31, 2019 · 5 comments

Comments

@R0dri
Copy link

R0dri commented Oct 31, 2019

After the latest PR #36 error at configuration of cask appears:
image

It looks like there is a new conflicting package:

Seems like there is now a font-sudo Cask, so this check breaks cask install:

if 'sudo' in result:
return 'Config'
I guess this check is there in case you changed HOMEBREW_CASK_OPTS? Maybe there's a better way to check for that?
by @ErikMinekus

This is a not so elegant solution I made. Probably breaks the purpose of the if in the first place:

 if 'sudo' in result:
     if 'font-sudo' not in result:
          return 'Config'
@fniephaus
Copy link
Owner

I wonder if this check and infrastructure is still needed at all...if I understand correctly, brew ships with cask out-of-the-box, right?

@R0dri
Copy link
Author

R0dri commented Oct 31, 2019

That is true, cask does come with brew. So if brew.py has an infrastructure check then this if is just a redundancy.

@TerminalFi
Copy link
Contributor

I wonder if this check and infrastructure is still needed at all...if I understand correctly, brew ships with cask out-of-the-box, right?

This is what I am testing and researching now. It appears to be no longer required. I am testing on fresh installs and 100 ~ package installs.

@TerminalFi
Copy link
Contributor

Fixed in #40

@fniephaus
Copy link
Owner

Should be fixed in v5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants