Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getUniProtToIDMapping or getConvTable? #25

Open
skiaphrene opened this issue Nov 12, 2024 · 1 comment
Open

getUniProtToIDMapping or getConvTable? #25

skiaphrene opened this issue Nov 12, 2024 · 1 comment

Comments

@skiaphrene
Copy link

Hi, this isn't really an issue, but a call for clarification...
I don't think it's clear what the difference is between getUniProtToIDMapping() and getConvTable(). They clearly give different results, but I don't understand the difference from the manual pages.

I am working with C. elegans, so if I call:
einprot::getUniProtToIDMapping("roundworm")
I get a data.frame mapping UniProt IDs to Gene Names / Symbols.

If I call:
einprot::getConvTable(type = "WormBase")
I get a data.frame mapping UniProt IDs to WormBase IDs. The latter has more mappings.

I need to use both, of course! :-)

Would it make sense to have a function that returned both mappings? Or a single function that could return either mapping? Or if the underlying code is so different, explain that in the help files, and add each function as a "See also" entry in the help file? Would it make sense to unify the argument specifications to each (e.g. "C. elegans" for both)? Just some ideas for clarification!

@csoneson
Copy link
Collaborator

Yes, fair point - the functions were originally written for different purposes, but I think it can indeed be simplified. I'll add it to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants