From 6deee74e90c389afd87b6a07fd57c3168619dc80 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Wed, 11 Dec 2024 01:15:54 +0100 Subject: [PATCH] Test and fix docs for Bazel 8 (#141) --- .bazelversion | 2 +- .bcr/presubmit.yml | 2 +- .github/workflows/ci.yaml | 2 +- MODULE.bazel | 2 +- docs/defs.md | 4 ++-- examples/.bazelversion | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.bazelversion b/.bazelversion index 815da58..ae9a76b 100644 --- a/.bazelversion +++ b/.bazelversion @@ -1 +1 @@ -7.4.1 +8.0.0 diff --git a/.bcr/presubmit.yml b/.bcr/presubmit.yml index f98fb2b..03b0db2 100644 --- a/.bcr/presubmit.yml +++ b/.bcr/presubmit.yml @@ -2,7 +2,7 @@ bcr_test_module: module_path: "examples" matrix: platform: ["debian10", "macos_arm64", "ubuntu2004"] - bazel: ["6.x", "7.x"] + bazel: ["6.x", "7.x", "8.x"] tasks: run_tests: name: "Run test module" diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 420b330..2e63787 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -25,7 +25,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-22.04, macos-14, windows-2022] - bazelversion: [6.5.0, latest, last_green] + bazelversion: [6.5.0, 7.4.1, latest, last_green] folder: [examples] include: - os: ubuntu-22.04 diff --git a/MODULE.bazel b/MODULE.bazel index 361a37b..61bd5e9 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -16,7 +16,7 @@ bazel_dep(name = "rules_testing", version = "0.4.0", dev_dependency = True) bazel_dep(name = "rules_java", version = "7.6.1", dev_dependency = True) bazel_dep(name = "rules_proto", version = "6.0.0", dev_dependency = True) bazel_dep(name = "stardoc", version = "0.7.2", dev_dependency = True) -bazel_dep(name = "toolchains_protoc", version = "0.3.0", dev_dependency = True) +bazel_dep(name = "toolchains_protoc", version = "0.3.6", dev_dependency = True) protoc = use_extension( "@toolchains_protoc//protoc:extensions.bzl", diff --git a/docs/defs.md b/docs/defs.md index f4b7361..46cdc5c 100644 --- a/docs/defs.md +++ b/docs/defs.md @@ -9,7 +9,7 @@
 load("@with_cfg.bzl", "original_settings")
 
-original_settings(name)
+original_settings(*, name)
 
Stores the original settings modified by a "resettable" rule constructed with `with_cfg`. @@ -57,7 +57,7 @@ original_settings(
 load("@with_cfg.bzl", "with_cfg")
 
-with_cfg(kind, executable, implicit_targets, extra_providers)
+with_cfg(kind, *, executable, implicit_targets, extra_providers)
 
Creates a new rule out of an existing one with modified Bazel flags or build settings. diff --git a/examples/.bazelversion b/examples/.bazelversion index 815da58..ae9a76b 100644 --- a/examples/.bazelversion +++ b/examples/.bazelversion @@ -1 +1 @@ -7.4.1 +8.0.0