Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill command now supports failure-policy #1840

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Sep 19, 2023

TL;DR

Adds new --no-fail-fast option to use WorkflowFailurePolicy.FAIL_AFTER_EXECUTABLE_NODES_COMPLETE

Screenshot 2023-09-18 at 10 27 46 PM

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@d9a6523). Click here to learn what that means.
Patch coverage: 15.38% of modified lines in pull request are covered.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1840   +/-   ##
=========================================
  Coverage          ?   20.11%           
=========================================
  Files             ?      336           
  Lines             ?    32286           
  Branches          ?     5841           
=========================================
  Hits              ?     6495           
  Misses            ?    25619           
  Partials          ?      172           
Files Changed Coverage Δ
flytekit/clis/sdk_in_container/backfill.py 0.00% <0.00%> (ø)
tests/flytekit/unit/remote/test_remote.py 0.00% <0.00%> (ø)
flytekit/remote/backfill.py 18.18% <33.33%> (ø)
flytekit/remote/remote.py 21.08% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kumare3 kumare3 merged commit 716fde3 into master Sep 21, 2023
68 checks passed
@kiliangojek
Copy link
Contributor

Tested on my side and it worked. Thanks @kumare3 for the quick implementation!

Future-Outlier pushed a commit to Future-Outlier/flytekit that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants