Upgrade testcontainers #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <[email protected]>
honnix
commented
Oct 9, 2023
| @@ -58,6 +58,10 @@ private static void startContainer() { | |||
| IOUtils.copy(imageInputStream, outputStream); | |||
| } | |||
|
|
|||
| // for some reason, when running on Mac, the above copied file is not fully ready after the | |||
| // stream being closed; sleeping a little bit could work around that | |||
| Thread.sleep(1000); | |||
There was a problem hiding this comment.
This is pretty strange and it is not about unflushed stream because I tried.
honnix
commented
Oct 9, 2023
| @@ -52,8 +55,12 @@ public class S3FileSystemIT { | |||
| public void setUp() { | |||
| s3 = | |||
| AmazonS3ClientBuilder.standard() | |||
| .withEndpointConfiguration(localStack.getEndpointConfiguration(S3)) | |||
honnix
commented
Oct 9, 2023
| @@ -79,7 +78,7 @@ protected void after() { | |||
| @Override | |||
| public void close() { | |||
| if (initialized.getAndSet(false)) { | |||
| ResourceReaper.instance().removeNetworkById(NAME); | |||
honnix
commented
Oct 9, 2023
| @@ -44,7 +44,7 @@ public class FlyteSandboxClient { | |||
| public static FlyteSandboxClient create() { | |||
| String version = String.valueOf(System.currentTimeMillis()); | |||
|
|
|||
| String address = FlyteSandboxContainer.INSTANCE.getContainerIpAddress(); | |||
honnix
commented
Oct 9, 2023
| @@ -106,9 +110,8 @@ public void start() { | |||
|
|
|||
| logger().info("Flyte is ready!"); | |||
|
|
|||
| String consoleUri = | |||
andresgomezfrr
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Upgrade testcontainers to latest version
Type
Are all requirements met?
Complete description
The current testcontainers doesn't play well with docker on mac. Upgrading to latest version seems to be better.
Tracking Issue
NA
Follow-up issue
NA