Fetch task template in dynamic workflow task #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <[email protected]>
honnix
commented
Sep 29, 2023
| @@ -185,34 +184,38 @@ public TaskIdentifier fetchLatestTaskId(NamedEntityIdentifier taskId) { | |||
| return fetchLatestResource( | |||
| taskId, | |||
| request -> stub.listTasks(request).getTasksList(), | |||
| TaskOuterClass.Task::getId, | |||
There was a problem hiding this comment.
This double-function doesn't seem to be necessary.
honnix
commented
Sep 29, 2023
| @@ -374,8 +375,10 @@ public static Map<WorkflowIdentifier, WorkflowTemplate> collectSubWorkflows( | |||
| .collect(toUnmodifiableMap()); | |||
| } | |||
|
|
|||
| public static Map<TaskIdentifier, TaskTemplate> collectTasks( | |||
| List<Node> rewrittenNodes, Map<TaskIdentifier, TaskTemplate> allTasks) { | |||
| public static Map<TaskIdentifier, TaskTemplate> collectDynamicWorkflowTasks( | |||
There was a problem hiding this comment.
Rename it to be more specific. This is not used by anything else.
honnix
commented
Sep 29, 2023
| @@ -138,33 +137,7 @@ public void shouldPropagateCreateTaskToStub() { | |||
| .version(TASK_VERSION) | |||
| .build(); | |||
|
|
|||
| TypedInterface interface_ = | |||
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
honnix
changed the title
andresgomezfrr
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fetch task template when encountering remote task in dynamic workflow.
Type
Are all requirements met?
Complete description
#248 is not sufficient because in order to build dynamic job, we need task template, so in this PR we fetch task template for remote workflow.
Tracking Issue
NA
Follow-up issue
NA