This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
Sending Audience to Device flow Initiation Request rather than Device Flow Token Request #317
Merged
pmahindrakar-oss
merged 4 commits into
flyteorg:audience-device-flow
from
shahwar9:audience-device-flow
Sep 9, 2022
Merged
Sending Audience to Device flow Initiation Request rather than Device Flow Token Request #317
pmahindrakar-oss
merged 4 commits into
flyteorg:audience-device-flow
from
shahwar9:audience-device-flow
Sep 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov Report
@@ Coverage Diff @@
## audience-device-flow #317 +/- ##
========================================================
- Coverage 73.11% 73.01% -0.11%
========================================================
Files 16 16
Lines 1023 1119 +96
========================================================
+ Hits 748 817 +69
- Misses 232 259 +27
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Congrats on merging your first pull request! 🎉 |
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2022
… Flow Token Request (#317) * Make consistent http request as later parts of orchestrator. * Revert change * Add audience in DeviceAuthorizationRequest and remove from DeviceAccessTokenRequest. * Add Audience field to values sent in StartDeviceAuthorization. Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2022
… Flow Token Request (#317) * Make consistent http request as later parts of orchestrator. * Revert change * Add audience in DeviceAuthorizationRequest and remove from DeviceAccessTokenRequest. * Add Audience field to values sent in StartDeviceAuthorization. Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 13, 2022
… Flow Token Request (#317) * Make consistent http request as later parts of orchestrator. * Revert change * Add audience in DeviceAuthorizationRequest and remove from DeviceAccessTokenRequest. * Add Audience field to values sent in StartDeviceAuthorization. Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 16, 2022
… Flow Token Request (#317) * Make consistent http request as later parts of orchestrator. * Revert change * Add audience in DeviceAuthorizationRequest and remove from DeviceAccessTokenRequest. * Add Audience field to values sent in StartDeviceAuthorization. Signed-off-by: Prafulla Mahindrakar <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read then delete this section
- Make sure to use a concise title for the pull-request.
- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/