Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Sending Audience to Device flow Initiation Request rather than Device Flow Token Request #317

Merged

Conversation

shahwar9
Copy link

@shahwar9 shahwar9 commented Sep 8, 2022

Read then delete this section

- Make sure to use a concise title for the pull-request.

- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@welcome
Copy link

welcome bot commented Sep 8, 2022

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #317 (1fcff9b) into audience-device-flow (3b032cf) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@                   Coverage Diff                    @@
##           audience-device-flow     #317      +/-   ##
========================================================
- Coverage                 73.11%   73.01%   -0.11%     
========================================================
  Files                        16       16              
  Lines                      1023     1119      +96     
========================================================
+ Hits                        748      817      +69     
- Misses                      232      259      +27     
  Partials                     43       43              
Flag Coverage Δ
unittests 73.09% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
clients/go/admin/deviceflow/token_orchestrator.go 64.19% <100.00%> (+1.85%) ⬆️
clients/go/admin/config_flags.go 59.57% <0.00%> (-3.22%) ⬇️
clients/go/admin/token_source.go 76.47% <0.00%> (-2.11%) ⬇️
clients/go/admin/client.go 84.48% <0.00%> (-0.67%) ⬇️
clients/go/admin/cert_loader.go 100.00% <0.00%> (ø)
clients/go/admin/token_source_provider.go 21.58% <0.00%> (+0.15%) ⬆️
clients/go/coreutils/literals.go 93.34% <0.00%> (+0.37%) ⬆️
clients/go/coreutils/extract_literal.go 86.79% <0.00%> (+0.79%) ⬆️
clients/go/admin/pkce/auth_flow_orchestrator.go 63.04% <0.00%> (+1.67%) ⬆️
clients/go/admin/authtype_enumer.go 27.27% <0.00%> (+2.27%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pmahindrakar-oss pmahindrakar-oss marked this pull request as ready for review September 9, 2022 05:31
@pmahindrakar-oss pmahindrakar-oss merged commit 03ac8c3 into flyteorg:audience-device-flow Sep 9, 2022
@welcome
Copy link

welcome bot commented Sep 9, 2022

Congrats on merging your first pull request! 🎉

pmahindrakar-oss pushed a commit that referenced this pull request Sep 9, 2022
… Flow Token Request (#317)

* Make consistent http request as later parts of orchestrator.

* Revert change

* Add audience in DeviceAuthorizationRequest and remove from DeviceAccessTokenRequest.

* Add Audience field to values sent in StartDeviceAuthorization.

Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss pushed a commit that referenced this pull request Sep 9, 2022
… Flow Token Request (#317)

* Make consistent http request as later parts of orchestrator.

* Revert change

* Add audience in DeviceAuthorizationRequest and remove from DeviceAccessTokenRequest.

* Add Audience field to values sent in StartDeviceAuthorization.

Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss pushed a commit that referenced this pull request Sep 13, 2022
… Flow Token Request (#317)

* Make consistent http request as later parts of orchestrator.

* Revert change

* Add audience in DeviceAuthorizationRequest and remove from DeviceAccessTokenRequest.

* Add Audience field to values sent in StartDeviceAuthorization.

Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss pushed a commit that referenced this pull request Sep 16, 2022
… Flow Token Request (#317)

* Make consistent http request as later parts of orchestrator.

* Revert change

* Add audience in DeviceAuthorizationRequest and remove from DeviceAccessTokenRequest.

* Add Audience field to values sent in StartDeviceAuthorization.

Signed-off-by: Prafulla Mahindrakar <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants