Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tab not spaces #837

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix: tab not spaces #837

merged 1 commit into from
Feb 15, 2024

Conversation

trutx
Copy link
Contributor

@trutx trutx commented Feb 10, 2024

TL;DR

make pack target doesn't work because a rogue space at the beginning of the line. Removing that so the target works again.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Running make pack doesn't work:

$ make pack
make: Nothing to be done for 'pack'.

This is due to a space at the start of the line. Removing it so only a tab remains, which is a requirement for Makefile format. Once done the target works as expected:

$ make pack
yarn run build:pack
➤ YN0000: [@flyteorg/common]: Process started
➤ YN0000: [@flyteorg/common]: No matches found: "**.tsbuildinfo"
➤ YN0000: [@flyteorg/common]: Process exited (exit code 0), completed in 8s 258ms

➤ YN0000: [@flyteorg/flyte-api]: Process started
➤ YN0000: [@flyteorg/flyte-api]: No matches found: "**.tsbuildinfo"
➤ YN0000: [@flyteorg/flyte-api]: Process exited (exit code 0), completed in 7s 830ms

➤ YN0000: [@flyteorg/flyteidl-types]: Process started
➤ YN0000: [@flyteorg/flyteidl-types]: No matches found: "**.tsbuildinfo"
➤ YN0000: [@flyteorg/flyteidl-types]: Process exited (exit code 0), completed in 7s 793ms

➤ YN0000: [@flyteorg/locale]: Process started
➤ YN0000: [@flyteorg/locale]: Process exited (exit code 0), completed in 7s 406ms

➤ YN0000: [@flyteorg/ui-atoms]: Process started
➤ YN0000: [@flyteorg/ui-atoms]: No matches found: "**.tsbuildinfo"
➤ YN0000: [@flyteorg/ui-atoms]: Process exited (exit code 0), completed in 8s 650ms

➤ YN0000: [@flyteorg/components]: Process started
➤ YN0000: [@flyteorg/components]: Process exited (exit code 0), completed in 8s 928ms

➤ YN0000: [@flyteorg/console]: Process started
➤ YN0000: [@flyteorg/console]: Process exited (exit code 0), completed in 22s 764ms
➤ YN0000: Done in 1m 12s

Tracking Issue

flyteorg/flyte#4892

Follow-up issue

N/A

Copy link

welcome bot commented Feb 10, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Signed-off-by: Roger Torrentsgenerós <[email protected]>
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfc38e4) 63.17% compared to head (68f3482) 63.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   63.17%   63.17%           
=======================================
  Files         528      528           
  Lines       13449    13449           
  Branches     2567     2567           
=======================================
  Hits         8497     8497           
  Misses       4952     4952           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit a162fb0 into flyteorg:master Feb 15, 2024
12 checks passed
Copy link

welcome bot commented Feb 15, 2024

Congrats on merging your first pull request! 🎉

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.10.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants