Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark NamedEntityState reserved enum values #5975

Merged

Conversation

katrogan
Copy link
Contributor

@katrogan katrogan commented Nov 8, 2024

Why are the changes needed?

Protobuf conflicts

What changes were proposed in this pull request?

Reserves wire numbers for enum values in NamedEntityState

How was this patch tested?

N/A

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.90%. Comparing base (b5f23a6) to head (d6a9c59).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5975   +/-   ##
=======================================
  Coverage   36.90%   36.90%           
=======================================
  Files        1310     1310           
  Lines      131372   131372           
=======================================
  Hits        48477    48477           
  Misses      78682    78682           
  Partials     4213     4213           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.05% <ø> (ø)
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.39% <ø> (ø)
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.84% <ø> (ø)
unittests-flytepropeller 42.90% <ø> (ø)
unittests-flytestdlib 55.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 25cfe16 into master Nov 8, 2024
50 of 51 checks passed
@eapolinario eapolinario deleted the katrina/cor-2225-mark-reserved-fields-in-oss-flyteidl branch November 8, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants