Fix indentation for security block in auth_setup.rst #5968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe `security` belongs under `server`. Without making this change, the auth didn't work for me. I further checked this by noting that the example helm file listed on https://artifacthub.io/packages/helm/flyte/flyte-core also places `security` under `server` `configmap.adminServer.server.security.useAuth` Signed-off-by: jkh <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5968 +/- ##
=======================================
Coverage 36.86% 36.86%
=======================================
Files 1310 1310
Lines 131246 131246
=======================================
Hits 48380 48380
Misses 78668 78668
Partials 4198 4198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
davidmirror-ops
approved these changes
Nov 7, 2024
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe
securitybelongs underserver.Without making this change, the auth didn't work for me.
I further checked this by noting that
securityunderserversecurityunderserver:configmap.adminServer.server.security.useAuthWhy are the changes needed?
Wan't able to get auth working without it
What changes were proposed in this pull request?
put
securityunderneathserverHow was this patch tested?
Tested it with an on prem deploy.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link