Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray Plugin - Use serviceAccount from Config if set #5928

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

peterghaddad
Copy link
Contributor

@peterghaddad peterghaddad commented Oct 28, 2024

Tracking issue

Closes #5821

Why are the changes needed?

These changes are necessary because the SA is pulled from the k8s context regardless of what's set in the config.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.95%. Comparing base (1279740) to head (1490254).
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5928      +/-   ##
==========================================
+ Coverage   36.53%   36.95%   +0.41%     
==========================================
  Files        1249     1310      +61     
  Lines      128230   131401    +3171     
==========================================
+ Hits        46847    48555    +1708     
- Misses      77346    78632    +1286     
- Partials     4037     4214     +177     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (?)
unittests-flyteadmin 54.07% <ø> (-0.07%) ⬇️
unittests-flytecopilot 22.23% <ø> (+10.50%) ⬆️
unittests-flytectl 62.39% <ø> (-0.02%) ⬇️
unittests-flyteidl 6.95% <ø> (+0.03%) ⬆️
unittests-flyteplugins 53.84% <100.00%> (+0.20%) ⬆️
unittests-flytepropeller 43.08% <ø> (+0.07%) ⬆️
unittests-flytestdlib 55.30% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: e356161 <[email protected]>
Signed-off-by: e356161 <[email protected]>
@peterghaddad peterghaddad force-pushed the ray-sa branch 2 times, most recently from 3e41aa8 to 00df7cd Compare October 28, 2024 13:17
Signed-off-by: e356161 <[email protected]>
@peterghaddad
Copy link
Contributor Author

@eapolinario let me know your thoughts!

@eapolinario eapolinario merged commit be67457 into flyteorg:master Nov 11, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants