[BUG] Flytepropeller Should show loglinks in RUNNING Phase

[Future-Outlier]

Describe the bug

Now, when using agent with loglinks and RUNNING phase, we can't show loglinks.

Expected behavior

We should show loglinks like the initialize phase does.

Additional context to reproduce

If you remove these 3 lines, loglinks will never be printed in any phase.

Screenshots

No response

Are you sure this issue hasn't been raised already?

• Yes

Have you read the Code of Conduct?

• Yes

[dosubot]

🤖

Hey @Future-Outlier, great to see you back here! Hope you're doing well. Let's dive into this issue you've raised.

Thank you for bringing this to our attention. It seems like the loglinks are not being displayed during the RUNNING phase of the Flytepropeller. This is likely due to the fact that the loglinks are initialized in the initialize phase and are not being updated or re-initialized in the RUNNING phase.

The loglinks are set up as part of the configuration in the initialize phase, as shown in the InitializeLogPlugins function in the logging_utils.go file. This function initializes log plugins based on the provided configuration (cfg). For each type of log (Kubernetes, Cloudwatch, Stackdriver), it checks if it is enabled in the configuration. If it is, it appends a TemplateLogPlugin to the plugins slice. This plugin contains the DisplayName and TemplateURIs which are used to generate the log links.

For dynamic log links, it iterates over cfg.DynamicLogLinks and appends a TemplateLogPlugin for each dynamic log link to the dynamicPlugins slice. This function returns a templateLogPluginCollection which contains both the static and dynamic plugins. These plugins are then used to generate the log links.

However, during the RUNNING phase, the handleRunningWorkflow function in the executor.go file is executed, which does not seem to update or re-initialize the loglinks. This could be the reason why the loglinks are not being displayed during the RUNNING phase.

You mentioned that if you remove certain lines, the loglinks will never be printed in any phase. Could you please specify which lines you are referring to? This could help us understand the issue better and find a suitable solution.

In the meantime, a potential workaround could be to manually call the InitializeLogPlugins function during the RUNNING phase to update the loglinks. However, this might not be the most efficient solution as it would re-initialize the loglinks every time the RUNNING phase is executed, which could potentially slow down the execution of the workflow.

We will continue to investigate this issue and try to find a more efficient solution. Your feedback is greatly appreciated and will help us improve the Flytepropeller. If you have any further information or suggestions, please feel free to share them.

For more information about the loglinks and how they are used in Flytepropeller, you can refer to the following sources:

• flyteplugins/go/tasks/logs/config.go
• flyteplugins/go/tasks/logs/logging_utils.go
• flytepropeller/pkg/controller/workflow/executor.go

Here is a link to my profile if you need to reach out for further assistance.

Sources

• flytepropeller/pkg/controller/workflow/executor.go
• flyteplugins/go/tasks/logs/config.go
• flyteplugins/go/tasks/logs/logging_utils.go

---

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

[pingsutw]

fixed by #5188