[Core feature] Introduce PhaseInfoFailureWithCleanup for non-recoverable pod states

[katrogan]

Motivation: Why do you think this is important?

For non-recoverable pod states, such as

flyte/flyteplugins/go/tasks/pluginmachinery/flytek8s/pod_helper.go

Lines 516 to 520 in 97a79c0

	case "CreateContainerConfigError", "InvalidImageName":
	t := c.LastTransitionTime.Time
	return pluginsCore.PhaseInfoFailure(finalReason, finalMessage, &pluginsCore.TaskInfo{
	OccurredAt: &t,
	}), nil

We should introduce a PhaseInfoFailureWithCleanup method similar to

flyte/flyteplugins/go/tasks/pluginmachinery/flytek8s/pod_helper.go

Line 525 in 97a79c0

return pluginsCore.PhaseInfoRetryableFailureWithCleanup(finalReason, finalMessage, &pluginsCore.TaskInfo{

to ensure the pod is cleaned up

Goal: What should the final outcome look like, ideally?

Invalid pods should result in workflow failure and be eventually cleaned up

Describe alternatives you've considered

Current implementation: leaves pod hanging indefinitely

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

• Yes

Have you read the Code of Conduct?

• Yes

[katrogan]

cc @hamersaw

[adarsh-jha-dev]

Hey @katrogan , could you please assign me this issue ?

[pvditt]

Hi @adarsh-jha-dev, would you mind if I took this issue over? I need to add a PhaseInfoFailureWithCleanup function to wrap up an issue with map tasks